GNOME Bugzilla – Bug 344657
Ctrl-H doesn't toggle "Show Hidden Files" setting
Last modified: 2007-03-23 05:19:04 UTC
Hitting Ctrl-H in a file chooser dialog doesn't toggle the display of hidden files.
Created attachment 68498 [details] [review] gtkfilechooser-show-hidden-on-keypress.patch This adds CTRL+H support for gtkfilechooser.
The problem with making this a (changeable) binding is that we always have the H underlined in the menu item, even if the user changes it to something else. Also, it is problematic for translations. E.g in German, the menu item is "_Verborgene Dateien anzeigen".
Doesn't menu accelerators use alt+letter? And what menu are are you talking about, because I do not see any menus in filechooser :(
The context menu on the file list
(In reply to comment #2) > The problem with making this a (changeable) binding is that we > always have the H underlined in the menu item, even if the user > changes it to something else. So if I understand you correctly, Shift+F10, H would access it. So why would Ctrl+H be a problem? > Also, it is problematic for translations. E.g in German, the > menu item is "_Verborgene Dateien anzeigen". I can see this being a problem for many keybindings. Would Ctrl+L be a problem, or e.g. Ctrl+F for Find (German 'Suchen', IIRC)? Having Ctrl+H here seems no different.
Since nautilus uses control+H, you expect to see hidden files with control+H on the chooser too.
I strongly support this: CTRL+h should toggle the hidden files view. I cannot see any problem with accesskeys in this.
Created attachment 85144 [details] [review] Updated patch which also removes some formfeed characters from the file I updated the patch such that it applies cleanly against current SVN. Please give all the credit to Priit when it gets applied. Matthias (or one of the other maintainers) if you agree with the other people please apply the patch. I like the other people also do not see any reason why Ctrl+H cannot be used to show the hidden files in the filechooser. Thanks
Retracting my objection. 2007-03-23 Matthias Clasen <mclasen@redhat.com> * gtk/gtkfilechooserdefault.c: Add a keybinding (C-h) to toggle whether to show hidden files. (#344657, Wouter Bolsterlee, Priit Laes, et al)