GNOME Bugzilla – Bug 344642
tools/gst-inspect.c does not compile if --disable-nls is used
Last modified: 2006-07-18 10:39:06 UTC
Please describe the problem: We do not have gettext support in our product, and thus we configure gstreamer using the --disable-nls option. However, with 0.10.7 and 0.10.8 the compilation of tools/gst-inspect.h fails. This is due to the unconditional inclusion of libintl.h and the use of ngettext(). The correct solution is to include gst/gettext.h rather than libintl.h. This is done through gst/gst-i18n-app.h, but it is only done when ENABLE_NLS is defined. This is wrong IMHO, and gettext.h should be included unconditionally since it provides fallback macros in case NLS is disabled. The attached patch will make the inclusion of gettext.h unconditional in gst/gst-i18n-app.h and gst/gst-i18n-lib.h, and it will remove the inclusion of libintl.h in tools/gst-inspect.c. Steps to reproduce: Configure using --disable-nls and rebuild. Actual results: The compilation fails. Expected results: The compilation to suceed. Does this happen every time? Yes. Other information:
Created attachment 67170 [details] [review] Allow use of --disable-nls again
Patch by: Peter Kjellerstedt <pkj at axis dot com> * gst/gst-i18n-app.h: * gst/gst-i18n-lib.h: * tools/gst-inspect.c: (print_signal_info): The attached patch will make the inclusion of gettext.h unconditional in gst/gst-i18n-app.h and gst/gst-i18n-lib.h, and it will remove the inclusion of libintl.h in tools/gst-inspect.c. This allows use of --disable-nls again and fixes #344642.