After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 344642 - tools/gst-inspect.c does not compile if --disable-nls is used
tools/gst-inspect.c does not compile if --disable-nls is used
Status: VERIFIED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.7
Other All
: Normal minor
: 0.10.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-06-12 10:40 UTC by Peter Kjellerstedt
Modified: 2006-07-18 10:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Allow use of --disable-nls again (1.89 KB, patch)
2006-06-12 10:42 UTC, Peter Kjellerstedt
committed Details | Review

Description Peter Kjellerstedt 2006-06-12 10:40:28 UTC
Please describe the problem:
We do not have gettext support in our product, and thus we configure gstreamer using the --disable-nls option.  However, with 0.10.7 and 0.10.8 the compilation of tools/gst-inspect.h fails.  This is due to the unconditional inclusion of libintl.h and the use of ngettext().

The correct solution is to include gst/gettext.h rather than libintl.h.  This is done through gst/gst-i18n-app.h, but it is only done when ENABLE_NLS is defined.  This is wrong IMHO, and gettext.h should be included unconditionally since it provides fallback macros in case NLS is disabled.

The attached patch will make the inclusion of gettext.h unconditional in gst/gst-i18n-app.h and gst/gst-i18n-lib.h, and it will remove the inclusion of libintl.h in tools/gst-inspect.c.


Steps to reproduce:
Configure using --disable-nls and rebuild.

Actual results:
The compilation fails.

Expected results:
The compilation to suceed.

Does this happen every time?
Yes.

Other information:
Comment 1 Peter Kjellerstedt 2006-06-12 10:42:12 UTC
Created attachment 67170 [details] [review]
Allow use of --disable-nls again
Comment 2 Wim Taymans 2006-07-03 14:16:01 UTC
        Patch by: Peter Kjellerstedt <pkj at axis dot com>

        * gst/gst-i18n-app.h:
        * gst/gst-i18n-lib.h:
        * tools/gst-inspect.c: (print_signal_info):
        The attached patch will make the inclusion of gettext.h unconditional in
        gst/gst-i18n-app.h and gst/gst-i18n-lib.h, and it will remove the inclusion of
        libintl.h in tools/gst-inspect.c.
        This allows use of --disable-nls again and fixes #344642.