After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 344592 - 'M' should go to title menu if no DVD menu
'M' should go to title menu if no DVD menu
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: xine-lib backend
1.2.x
Other Linux
: Normal enhancement
: ---
Assigned To: Maintainer alias for xine-lib component of Totem
Maintainer alias for xine-lib component of Totem
Depends on:
Blocks:
 
 
Reported: 2006-06-11 17:34 UTC by Sven Arvidsson
Modified: 2006-10-29 19:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
xine-lib-try-title-menu-if-root-not-present.patch (817 bytes, patch)
2006-10-02 09:42 UTC, Bastien Nocera
none Details | Review

Description Sven Arvidsson 2006-06-11 17:34:28 UTC
This bug was reported to the Debian BTS.
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=369319

Package: totem
Version: 1.2.1-4
Severity: wishlist

I have some discs which do not seem to have a main DVD menu.  On these
discs, if I press 'M', totem does not go to the disc menu, and I see the
following message:

libdvdnav: *** pgci_ut handle is NULL ***

However, if I use the Go menu to access the Title menu, it takes me to
the normal menu for the disc.  Thus, I think that if I press 'M', and
Totem cannot find a DVD menu, it should go to the Title menu instead.
Comment 1 Bastien Nocera 2006-06-18 18:58:21 UTC
As GStreamer doesn't have support for DVD menus, this would a xine-lib specific problem.

The problem is that xine-lib can't send back an event from xine_event_send(). But dvdnav_menu_call does return whether there was an error. I'm not sure you got the correct error message though, it's supposed to say:
---8<---
    vm_free_copy(try_vm);
    printerr("No such menu or menu not reachable.");
    pthread_mutex_unlock(&this->vm_lock);
    return DVDNAV_STATUS_ERR;
---8<---
Comment 2 Bastien Nocera 2006-10-02 09:42:00 UTC
Created attachment 73835 [details] [review]
xine-lib-try-title-menu-if-root-not-present.patch

Patch to xine-lib's input_dvd.c
This will try to open the Title menu if the Root menu isn't available.
Comment 3 Bastien Nocera 2006-10-02 10:02:56 UTC
Please test the attached patch.
Comment 4 Bastien Nocera 2006-10-29 19:40:29 UTC
Fixed in xine-lib CVS.

revision 1.211
date: 2006/10/29 19:39:39;  author: hadess;  state: Exp;  lines: +3 -2
- if the root menu isn't available, go to the title menu instead. Closes
  GNOME Bugzilla:
  http://bugzilla.gnome.org/show_bug.cgi?id=344592