After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 344472 - [wavpackdec] should post audio codec tag and extract bitrate
[wavpackdec] should post audio codec tag and extract bitrate
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 0.10.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-06-10 11:22 UTC by Tim-Philipp Müller
Modified: 2006-08-24 09:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wavpackdec-tags.diff (3.43 KB, patch)
2006-08-23 12:24 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Tim-Philipp Müller 2006-06-10 11:22:23 UTC 
When playing a wavpack file, totem currently only shows the duration in the properties dialog. We should at least show the audio codec name and also the average bitrate (if applicable).
Comment 1 Sebastian Dröge (slomo) 2006-08-23 01:26:46 UTC 
The only way to get the average bitrate is by querying the upstream elements for the duration in TIME and BYTES format... would this be fine or would it be preferable to not show any average bitrate at all?
Comment 2 Sebastian Dröge (slomo) 2006-08-23 12:24:11 UTC 
Created attachment 71452 [details] [review]
wavpackdec-tags.diff

this patch posts GST_TAG_AUDIO_CODEC and if possible GST_TAG_BITRATE. for this the duration and position queries have to be forwared upstream in wavpackparse if the format can't be handled there.
Comment 3 Tim-Philipp Müller 2006-08-24 09:29:15 UTC 
Committed, thanks:

  2006-08-24  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Sebastian Dröge <slomo at circular-chaos.org>

        * ext/wavpack/gstwavpackdec.c: (gst_wavpack_dec_post_tags),
        (gst_wavpack_dec_chain):
          Post audio codec and average bitrate tags on bus (#344472).

        * ext/wavpack/gstwavpackparse.c: (gst_wavpack_parse_base_init),
        (gst_wavpack_parse_src_query):
          Forward queries in other formats (BYTE format in particular)
          upstream; add Sebastian to authors.

I changed the AUDIO_CODEC string to just "Wavpack" in both cases (mostly to avoid having to mark the string for translation for now, but also because it's more or less apparent from the bitrate anyway).