After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 344403 - Edit icons disabled on a NFS mounted Photos directory
Edit icons disabled on a NFS mounted Photos directory
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Browsing
CVS
Other Linux
: Normal normal
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2006-06-09 14:18 UTC by Bengt Thuree
Modified: 2007-02-14 16:59 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Bengt Thuree 2006-06-09 14:18:04 UTC
After I imported some photos to my NFS mounted Photos directory, I wanted to edit them a bit.
But the edit icons in Edit view were disabled.
I could "Edit -> Adjust color" as well as "Edit -> Sharpen" though.

If I linked the photo, instead of copy it, the edit icons were enabled.

Checking the PhotoView.cs gives me the following code around line 148
Gnome.Vfs.Uri vfs = new Gnome.Vfs.Uri  
          (photo_view.Item.Current.DefaultVersionUri.ToString ());
valid = vfs.IsLocal;

Seems like valid will always be false for a NFS mounted home directory. Or?
Comment 1 Bengt Thuree 2006-06-09 15:01:13 UTC
Just checked the value of vfs.IsLocal and it is False for the NFS mounted home directory.

My fstab looks like this:
mackie:/home/bengt      /home/bengt     nfs     rsize=8192,wsize=8192,timeo=14,intr
Comment 2 Bengt Thuree 2006-06-10 13:46:30 UTC
version 1.88 of PhotoView.cs introduced the "valid=vfs.IsLocal" code.
Comment 3 Bengt Thuree 2006-09-08 06:32:38 UTC
Still a problem with 0.2.0
Comment 4 Larry Ewing 2006-10-05 03:47:51 UTC
The editing check is based on the gnome-vfs setting for a local file, I suppose we could check if the type of the uri is file: instead of checking if it it local.
Comment 5 Stephane Delcroix 2007-02-14 16:43:12 UTC
as for now, f-spot only supports file:// uris... so valid should be always true and we'll rethink that validity concept when f-spot will be able to deal with real uris everywhere...

as usual, it's only my humble opinion...
Comment 6 Stephane Delcroix 2007-02-14 16:59:11 UTC
fixed in r2953