After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 344326 - Cannot build selective gaussian blur on Solaris 8
Cannot build selective gaussian blur on Solaris 8
Status: VERIFIED FIXED
Product: GIMP
Classification: Other
Component: Plugins
2.3.x
Other Solaris
: Normal normal
: ---
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2006-06-08 19:55 UTC by Eric Lamarque
Modified: 2008-01-15 14:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
remove return in void matrixmult() (470 bytes, patch)
2006-06-08 19:57 UTC, Eric Lamarque 		none Details | Review
updated patch to restore return in macro EXPAND (683 bytes, patch)
2006-06-08 20:53 UTC, Eric Lamarque 		none Details | Review

Description Eric Lamarque 2006-06-08 19:55:52 UTC 
void matrixmult() function includes return

the trivial patch removes return in macro EXPAND()
Comment 1 Eric Lamarque 2006-06-08 19:57:12 UTC 
Created attachment 66999 [details] [review]
remove return in void matrixmult()
Comment 2 Simon Budig 2006-06-08 20:12:16 UTC 
Ok, this patch is not correct, since it omits the functionality of the "return". But this should be easily fixable in the Macro.
Comment 3 Michael Natterer 2006-06-08 20:34:34 UTC 
What's wrong with that macro? The preprocessor is supposed to be a text
mangling engine, not something that looks at the text substituted.
I'd say this is a broken preprocessor.
Comment 4 Michael Natterer 2006-06-08 20:43:19 UTC 
Ehm, ignore my last comment. Of course the preprocessor doesn't
care about the return, you meant the function itself has no
return value :)
Comment 5 Eric Lamarque 2006-06-08 20:53:50 UTC 
Created attachment 67001 [details] [review]
updated patch to restore return in macro EXPAND
Comment 6 Simon Budig 2006-06-08 21:08:08 UTC 
Thanks for the patch, had already fixed it in my local tree and its now in CVS:

2006-06-08  Simon Budig  <simon@gimp.org>

        * plug-ins/common/sel_gauss.c: fix the EXPAND macro to make
        picky compilers happy. Fixes bug #344326, spotted by
        Eric Lamarque.