After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 344140 - [eog-ng] remove duplicate code in fullscreen-code
[eog-ng] remove duplicate code in fullscreen-code
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: image viewer
git master
Other All
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-06-07 12:04 UTC by Felix Riemann
Modified: 2006-06-25 13:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
remove duplicate code (1.68 KB, patch)
2006-06-07 12:06 UTC, Felix Riemann 		committed Details | Review

Description Felix Riemann 2006-06-07 12:04:16 UTC 
The timeout for hiding the toolbar in fullscreen is cleared in several cases. In some of these cases there was code copied which does the same as the code in fullscreen_clear_timeout().
Comment 1 Felix Riemann 2006-06-07 12:06:20 UTC 
Created attachment 66908 [details] [review]
remove duplicate code

This patch removes the duplicate code and replaces it by function calls to fullscreen_clear_timeout ().
Comment 2 Claudio Saavedra 2006-06-25 13:15:37 UTC 
Thank you Felix. Commited to eog-ng branch.

2006-06-25  Claudio Saavedra  <csaavedra@alumnos.utalca.cl>

        * shell/eog-window.c: (fullscreen_timeout_cb),
        (fullscreen_set_timeout), (eog_window_dispose):
        Remove some duplicated code and use fullscreen_clear_timeout () instead
        of it (Fixes bug #344140). Patch from Felix Riemann <felix@hsgheli.de>.