After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 344129 - [directsoundsrc] Plugin for Directsound source
[directsoundsrc] Plugin for Directsound source
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal enhancement
: 0.10.14
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-06-07 11:03 UTC by Joni Valtanen
Modified: 2009-08-10 09:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
directsoundsrc source file (21.22 KB, text/x-csrc)
2006-06-07 11:06 UTC, Joni Valtanen
  Details
directsoundsrc header file (3.61 KB, text/x-chdr)
2006-06-07 11:07 UTC, Joni Valtanen
  Details
Directsound plugin source, sink and Makefile.am patch (31.26 KB, patch)
2006-09-05 11:29 UTC, Joni Valtanen
none Details | Review
configure.ac patch (1.46 KB, patch)
2006-09-05 11:42 UTC, Joni Valtanen
committed Details | Review
Patch to sys:s Makefile.am (504 bytes, patch)
2006-09-05 11:43 UTC, Joni Valtanen
committed Details | Review
Makefile.am patch to DirectDraw (752 bytes, patch)
2006-09-05 11:52 UTC, Joni Valtanen
committed Details | Review
New patch for directsoundsrc (28.41 KB, patch)
2007-05-31 05:12 UTC, Joni Valtanen
committed Details | Review

Description Joni Valtanen 2006-06-07 11:03:03 UTC
There is no Directsound source. I have written one. It is not complete yet, but it should work with 44100 16-bit mono/stereo.

This is my first "real" GStreamer plugin so comments are very wellcome. Eighter I am not a Windows programmer. So comments and pathes please.
Comment 1 Joni Valtanen 2006-06-07 11:06:23 UTC
Created attachment 66903 [details]
directsoundsrc source file

Rate Directsoundsrc source files
Comment 2 Joni Valtanen 2006-06-07 11:07:58 UTC
Created attachment 66904 [details]
directsoundsrc header file

directsoundsrc headerfile
Comment 3 Joni Valtanen 2006-06-07 11:10:21 UTC
Comment on attachment 66903 [details]
directsoundsrc source file

Rare directsoundsrc source file
Comment 4 Joni Valtanen 2006-09-05 11:29:59 UTC
Created attachment 72239 [details] [review]
Directsound plugin source, sink and Makefile.am patch

This patch adds Directsoundsrc to directsound-plugin. There is also added Makefile.am and modified Directsoundsink to compile with DirectX7.
Comment 5 Joni Valtanen 2006-09-05 11:42:33 UTC
Created attachment 72240 [details] [review]
configure.ac patch

There is also directdrawsink included in this
Comment 6 Joni Valtanen 2006-09-05 11:43:20 UTC
Created attachment 72241 [details] [review]
Patch to sys:s Makefile.am

There is also directdrawsink included in this
Comment 7 Joni Valtanen 2006-09-05 11:52:16 UTC
Created attachment 72242 [details] [review]
Makefile.am patch to DirectDraw

I think there is no need to separate bug for this patch. This only adds Makefile.am to directdrawsink plugin.
Comment 8 Joni Valtanen 2006-09-08 07:18:08 UTC
There is problem with directsound capture buffers. On latest sound quality is bad and have to set sync to false if used with gst-launch. Like this gst-launch-0.10 directsoundsrc ! directsoundsink sync=false. 

When capture quality is fine and no sync needed. There is about 2s delay for outputting audio. I don't know is there problem with src and/or sink.

If any one have some experience capturing with directsound. Help needed.
Comment 9 Joni Valtanen 2006-09-08 07:30:52 UTC
Just tested that alsasrc/sink seems to work similar way as directsoundsrc/sink. hmm. yes. No I trey to make soundquality as good as possible.
Comment 10 Tim-Philipp Müller 2006-10-17 17:35:34 UTC
What's the status of this?

Are you still working on it/improving it, or should the directsoundsrc code be added to the directsound plugin in -bad as it is in the patch? (that is assuming it works of course)
Comment 11 Tim-Philipp Müller 2006-10-18 12:38:35 UTC
Oops, sorry, didn't realise no autotools stuff had been committed for this yet.
Comment 12 Joni Valtanen 2006-10-18 14:06:52 UTC
(In reply to comment #10)
> What's the status of this?
> 
> Are you still working on it/improving it, or should the directsoundsrc code be
> added to the directsound plugin in -bad as it is in the patch? (that is
> assuming it works of course)
> 

I am workin on it as soon as I have time. I think it works but it might work better. There is some finetuning to be done.

In my opinion it is not ready yet.
Comment 13 Marcin Lewandowski 2007-04-16 14:48:27 UTC
Are there any chances to get that working in the next month? I need to create multi-platform multimedia app and it would be nice to build it with GStreamer.
Comment 14 Joni Valtanen 2007-05-31 05:12:02 UTC
Created attachment 89085 [details] [review]
New patch for directsoundsrc

Better than last one, but not perfect.
Comment 15 Ali Sabil 2007-06-08 20:46:59 UTC
Will this element get included in the next -bad release ?
Comment 16 Tim-Philipp Müller 2007-06-10 11:17:23 UTC
> Will this element get included in the next -bad release ?

Somewhat unlikely with good/ugly/bad being frozen tomorrow. Have you tested it? Does it work well for you? IIRC I asked the author on IRC if he thought it was ready to be committed and he said he'd rather work on it some more before, or something along those lines.

 

Comment 17 Ali Sabil 2007-06-10 13:11:44 UTC
Nop, I didn't test it, but I can do that tomorrow (before the freeze), I have no windows machine nearby now. I think, that if it is at least a bit usable, it would be nice to include it (to -bad) so that people start contributing to it.
Comment 18 Julien Isorce 2008-07-01 14:36:36 UTC
Yop, I have tried to test it but I get the following ERROR: 
from element /pipeline0/directsoundsrc0: Unable to open dsound.dll
It seems the LoadLibrary("dsound.dll") failed. But it exists in system32.

J.

Comment 19 Julien Isorce 2008-07-02 22:22:00 UTC
hmm sorry it was about unicode, so the dll name was not reconized.

This plugin works fine. Why this plugin is not on the plugins-bad cvs repository ?

J.
Comment 20 Sebastian Dröge (slomo) 2009-07-29 13:36:20 UTC
Ok, I've committed this now to gst-plugins-bad. Please test if I broke anything while updating the patch. I can't unfortunately :)

commit 0ddbe127eed5f5a2d5af2f9141386aea793277de
Author: Joni Valtanen <joni.valtanen@movial.com>
Date:   Wed Jul 29 15:35:03 2009 +0200

    directsoundsrc: Add DirectSound source plugin
    
    Fixes bug #344129.
Comment 21 Julien Isorce 2009-07-29 17:06:38 UTC
ok I will do that next week.
Comment 22 Julien Isorce 2009-08-10 09:45:47 UTC
Can be built with vs8. But I cannot check if it can be build with msys/mingw because there is no "dsound.h" in the official mingw-win32-api package.

commit 4aea6354e0bddec37ac8b462e35f53a7f556abe8
Author: Julien Isorce <julien.isorce@gmail.com>
Date:   Mon Aug 10 11:40:13 2009 +0200

    directsoundsrc: add vs8 project

commit 94ece2054ca4d63a03dfa43dda8c2e9386c60c88
Author: Julien Isorce <julien.isorce@gmail.com>
Date:   Mon Aug 10 11:36:41 2009 +0200

    directsoundsrc: LF and indent