After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 344115 - [patch] make more internal data const
[patch] make more internal data const
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal trivial
: 0.10.9
Assigned To: Stefan Sauer (gstreamer, gtkdoc dev)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-06-07 08:07 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2006-07-11 22:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
make two members const (418 bytes, patch)
2006-06-07 08:07 UTC, Stefan Sauer (gstreamer, gtkdoc dev)
committed Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2006-06-07 08:07:06 UTC
two GstFlowQuarks members can be made const to save a little memory
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2006-06-07 08:07:48 UTC
Created attachment 66889 [details] [review]
make two members const
Comment 2 Wim Taymans 2006-06-08 08:14:35 UTC
there are few other instances in gstevent and gstmessage. 
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2006-06-08 11:49:45 UTC
I'll change GstEventQuarks and GstMessageQuarks after freeze together with those in gstpad.c
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2006-06-08 11:54:41 UTC
and another one in gstformat.c
struct _GstFormatDefinition
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2006-06-08 11:57:59 UTC
and in gstquery.h
struct _GstQueryTypeDefinition
Comment 6 Wim Taymans 2006-06-08 12:02:15 UTC
those last two would break API and cannot be changed.
Comment 7 Stefan Sauer (gstreamer, gtkdoc dev) 2006-06-08 13:20:37 UTC
indeed, moved the last two to #339744
Comment 8 Wim Taymans 2006-06-12 09:29:46 UTC
        Patch by: Stefan Kost <ensonic at sonicpulse dot de>

        * gst/gstevent.c: (gst_event_get_type):
        * gst/gstmessage.c:
        * gst/gstpad.c: (gst_pad_chain_unchecked), (gst_pad_chain),
        (gst_pad_push):
        constify quark registration strings. Fixes #344115
        Avoid unneeded type checking is _pad_push() by internally
        calling gst_pad_chain_unchecked().