After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 343951 - patch for win32+vs6
patch for win32+vs6
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other Windows
: Normal normal
: 0.10.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-06-05 21:39 UTC by Sebastien Moutte
Modified: 2006-09-06 15:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for gst-ffmpeg+vs6 (38.14 KB, patch)
2006-06-05 21:40 UTC, Sebastien Moutte 		committed Details | Review

Description Sebastien Moutte 2006-06-05 21:39:19 UTC 
Hi all,

I've built gst-ffmpeg with vs6 after some changes ...
Here is a patch for it.
I had to replace pix_fmt_info array initialization by a more standard way of tables init using a function.
I've also write a clean function to free strings allocated by g_strdup by i don't really where to call it ...

Cheers,
Sebastien
Comment 1 Sebastien Moutte 2006-06-05 21:40:22 UTC 
Created attachment 66794 [details] [review]
patch for gst-ffmpeg+vs6
Comment 2 Tim-Philipp Müller 2006-07-06 16:34:05 UTC 
Looks mostly good to me.

The only thing I'm not entirely sure about is the pix_fmt_info[] array change - can we keep this in sync with the stuff in ~/gst-plugins-base/gst/ffmpegcolorspace/ or is there a reason why this is not possible?
Comment 3 Wim Taymans 2006-09-06 15:15:06 UTC 
        Patch by: Sebastien Moutte <sebastien at moutte dot net>

        * ext/ffmpeg/gstffmpeg.c: (plugin_init):
        * ext/ffmpeg/gstffmpegcodecmap.c: (gst_ff_vid_caps_new),
        (gst_ff_aud_caps_new), (gst_ffmpeg_codecid_to_caps),
        (gst_ffmpeg_pixfmt_to_caps), (gst_ffmpeg_smpfmt_to_caps),
        (gst_ffmpeg_init_pix_fmt_info):
        * ext/ffmpeg/gstffmpegcodecmap.h:
        * ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_send_event):
        * ext/ffmpeg/gstffmpegprotocol.c:
        Make stuff compile on Visual Studio 6.
        Convert some crach macros to functions.
        Convert some static tables to _init functions.
        Fixes #343951.