After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 343733 - links dont work when pdf rotated
links dont work when pdf rotated
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
0.5.x
Other All
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-06-03 00:19 UTC by Bret Towe
Modified: 2006-12-09 16:46 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
patch of ev-view.c for implementation of working links in rotated documents (2.28 KB, patch)
2006-12-09 10:45 UTC, Radoslav Dorcik 		none Details | Review
changed patch of ev-view for resolve this bug (2.28 KB, patch)
2006-12-09 15:59 UTC, Radoslav Dorcik 		committed Details | Review

Description Bret Towe 2006-06-03 00:19:30 UTC 
Please describe the problem:
when rotating a pdf that has links none of the links work on any rotation


Steps to reproduce:
browsing any of the pdfs here:
http://www.mouser.com/index.cfm?handler=mousercatalog&map=mousercatalog626
and rotating left or right will show the issue


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Nickolay V. Shmyrev 2006-06-03 17:22:02 UTC 
Agree, they just aren't implemented yet.
Comment 2 Radoslav Dorcik 2006-12-09 10:45:01 UTC 
Created attachment 78008 [details] [review]
patch of ev-view.c for implementation of working links in rotated documents

i propose this patch - please comment how i can improve this code - since i'm little new to evince development.
Comment 3 Carlos Garcia Campos 2006-12-09 12:03:36 UTC 
Hi Radoslav, thanks a lot, the patch looks good to me. Just a minor comment, get_doc_point_from_offset() should be static, since it's private to ev-view. There is a comment in C++ format (//), please use C comments (/* */) instead.
Comment 4 Radoslav Dorcik 2006-12-09 15:59:22 UTC 
Created attachment 78031 [details] [review]
changed patch of ev-view for resolve this bug

Thanks for comment. Here is new version of patch with suggested changes.
Comment 5 Carlos Garcia Campos 2006-12-09 16:46:14 UTC 
Thank you very much. It's applied in cvs head now.