After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 343699 - oggmux leaks
oggmux leaks
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-06-02 17:43 UTC by Alessandro Decina
Modified: 2006-06-14 09:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix (4.41 KB, patch)
2006-06-02 17:44 UTC, Alessandro Decina 		committed Details | Review

Description Alessandro Decina 2006-06-02 17:43:52 UTC 
In gst_ogg_mux_get_headers the caps returned by gst_pad_get_negotiated_caps are not unref'fed.
When going to READY the GstOggPad structures managed by GstCollectPads are not properly reset, GstOggPad->pagebuffers is not free'd and GstOggPad->stream is not cleared with ogg_stream_clear.
Also, gst_ogg_mux_set_header_on_caps introduces a reference cycle setting the streamheader field, this has been fixed in vorbisenc and theoraenc but not in oggmux.
Comment 1 Alessandro Decina 2006-06-02 17:44:28 UTC 
Created attachment 66667 [details] [review]
Fix
Comment 2 Wim Taymans 2006-06-14 09:14:51 UTC 
Thanks, commited:

        Patch by: Alessandro Decina <alessandro at nnva dot org>

        * ext/ogg/gstoggmux.c: (gst_ogg_mux_get_type), (gst_ogg_mux_clear),
        (gst_ogg_mux_release_pad), (gst_ogg_mux_get_headers),
        (gst_ogg_mux_set_header_on_caps), (gst_ogg_mux_init_collectpads),
        (gst_ogg_mux_clear_collectpads), (gst_ogg_mux_change_state):
        Fix various leaks. Fixes #343699.
        Add x-smoke mime type.