After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 343524 - Patch to implement Notes support
Patch to implement Notes support
Status: RESOLVED FIXED
Product: yelp
Classification: Applications
Component: Info Pages
git master
Other All
: Normal enhancement
: ---
Assigned To: Yelp maintainers
Yelp maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-31 16:58 UTC by Don Scorgie
Modified: 2006-06-10 17:05 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
Notes support (8.87 KB, patch)
2006-05-31 17:03 UTC, Don Scorgie 		none Details | Review
Don't leak memory (9.00 KB, patch)
2006-05-31 18:03 UTC, Don Scorgie 		committed Details | Review

Description Don Scorgie 2006-05-31 16:58:31 UTC 
Attached in a minute for your pleasure
Comment 1 Don Scorgie 2006-05-31 17:03:37 UTC 
Created attachment 66549 [details] [review]
Notes support

This implements *Note and *note support in info pages to turn them into hyperlink clickys.

The bulk of the work is one function (that I'm sure can be split up a bit better) that basically deals with making hyperlinks and maintaining the formatting of the existing text so notes arn't too painful.  I've tested it on a few info pages and haven't come across any problems.

I know it still leaks like crazy, but I'll fix them before committing.  Any comments?  Can I commit (with fixed leaks)?
Comment 2 Shaun McCance 2006-05-31 17:10:42 UTC 
I'm not familiar with notes in info pages.  Can you give me the three-sentence executive overview of what they do?
Comment 3 Don Scorgie 2006-05-31 17:17:06 UTC 
Notes basically are info page links to different sections / info pages.  E.g.  In this sentence, *Note Overview:: would (in the info browser), when selected, go to the section of the current document with the Node name "Overview".  *Note Some Text:(gcc)Overview. would go to the gcc info page to the section "Overview".
Comment 4 Don Scorgie 2006-05-31 18:03:35 UTC 
Created attachment 66552 [details] [review]
Don't leak memory

Same as above, but without the memory leaks.
Comment 5 Don Scorgie 2006-06-10 17:05:54 UTC 
Patch has been committed to CVS HEAD.  Closing.