After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 343500 - [riff] gst_riff_parse_strf_vids() can't parse extra data.
[riff] gst_riff_parse_strf_vids() can't parse extra data.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-31 12:30 UTC by Young-Ho Cha
Modified: 2006-07-11 22:28 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
quick patch for get extra data properly (1.08 KB, patch)
2006-05-31 12:32 UTC, Young-Ho Cha 		none Details | Review
patch for get extra data properly (904 bytes, patch)
2006-06-01 13:47 UTC, Young-Ho Cha 		committed Details | Review

Description Young-Ho Cha 2006-05-31 12:30:50 UTC 
I'm using pitfdll plugin for playing wmv3 video.

But some avi files contain wmv3 video can't play.

so I trace some functions, and I found there is something invalid in riff parser.

When mplayer's aviparser get extra data from strf, starting offset is _BITMAPHEADER size_ not _strf size_.

but in gstriff, offset is _strf size_, so extra data is always empty.

After apply below patch, totem player can play avi files that couldn't play before.
Comment 1 Young-Ho Cha 2006-05-31 12:32:00 UTC 
Created attachment 66525 [details] [review]
quick patch for get extra data properly
Comment 2 Young-Ho Cha 2006-05-31 13:09:58 UTC 
You can download media file from http://ftp.mizi.com/~ganadist/sample.avi

File size is about 10Mb, and file contains wmv3 video and mp3 audio.
Comment 3 Young-Ho Cha 2006-06-01 13:47:40 UTC 
Created attachment 66594 [details] [review]
patch for get extra data properly

use sizeof(gst_riff_strf_vids) instead of fixed value
Comment 4 Wim Taymans 2006-06-16 13:59:57 UTC 
Thanks a lot, does not cause regressions with paletted files. Commited:

        Patch by: Young-Ho Cha <ganadist at chollian dot net>

        * gst-libs/gst/riff/riff-read.c: (gst_riff_parse_strf_vids):
        Parse extra data better, apparently it's right behind
        the normal strf header size. Fixes #343500.