GNOME Bugzilla – Bug 343437
Use correct size for launcher icons (on the panel and in the menu)
Last modified: 2015-03-24 13:01:03 UTC
That bug has been opened on https://launchpad.net/distros/ubuntu/+source/gnome-panel/+bug/34774 "When a KDE app appears on the Applications menu, it is rendered with the 16x16 application icon, even if higher res icons appear in /usr/share/icons/hicolor. However, adding a Custom Application Launcher item to the panel, specifying a KDE application and not setting the icon manually results in the panel displaying a higher-resolution icon (looks 32x32) ... http://librarian.launchpad.net/1710346/gnome-panel.png This shows several kde apps on the panel; the left icon was created with a Custom Application Launcher, the right icon was the result of dragging an app from the Applications menu. ... > Thanks for your bug. The 22x22 variant is used instead of the 24x24 variant. According to a discussion on IRC some days ago: "dobey: GTK+ isn't handling Threshold properly for close-range sizes like 22 vs. 24" Vincent, is gnome-panel asking for a 24x24 icon for 24 pixels panel? Have you an opinion on if we should use "Type=Fixed" for the 22x22 categories by example? ... I think you already fixed this, but anyway, there are good chances that gnome-panel is asking for a 24x24 icon for 24 pixels panel. And if it doesn't, it will for a 25px or 26px panel. I discussed with lapo about this, and he's right that adding padding in the panel should be okay. I have to try this. ... Forgot: feel free to open a bug upstream :-)"
What's weird about the screenshot is that both launchers are on the same panel. And they don't use the same icon. Is it possible to know which icon is used for both launchers?
Created attachment 70552 [details] [review] Patch Should fix most of such issues.
Looks good. Is this going into HEAD?
Not yet, for two reasons: + there are still some icons that are blurry in the menu when using 22x22 size + I'm still not convinced that the launchers look good when their size is 32x32 on a 44px panel. The first issue depends on g-i-t, I suppose. For the second issue, we might want to go back to propose standard sizes for the panel (small, medium, large) which would translate to 22, 32 and 48. This is 2.17 stuff.
The first issue actually depends on all the apps shipping icons at the size used by the panel. Since most third party applications, and plenty of the ones we consider to be part of GNOME, only ship a 48x48 png or possibly even larger, installed in $datadir/pixmaps, we're going to have some blurry icons no matter what. The icon theme is not going to be able to solve this. Think about users who install wine, and have icons in their menus, from Windows applications they install. They're going to end up with icons that look slightly blurry. Can you provide a list of the ones that you think are blurry, that we can solve in the apps we ship?
Rodney: IIRC, there were some category icons which were blurry. You can easily try it by adding this to your gtkrc: gtk-icon-sizes = "panel-menu=22,22" (hmmm, you might want to restart the panel since the icons don't get reloaded after the size change???)
Ah, you need to upgrade your gnome-icon-theme version I guess. After re-installing it here, the category icons look fine afaict (merged gnome/kde menus on SLED). I'd say that if there are any blurry category icons, just file bugs against gnome-icon-theme for them, assuming the icons are still blurry with HEAD. Aside from that, I agree that the 32px on a 40-47px panel will look a bit odd, but we can fix that for 2.17.
Vincent, your patch fixes all the "fuzzyness" problems I was seeing with 'Power Management' and the panel. The icons are all selected correctly now and are crisp and sharp. Has this patch been applied to 2-17? Thanks. Richard Hughes.
Richard: I haven't branch the panel, so it's not in yet :-)
CC'ing myself. See http://uwstopia.nl/blog/2006/11/fuzzy-menu-icons for more information.
Created attachment 76213 [details] Sizes requested by gnome-panel
Created attachment 76214 [details] Gtk icon theme lookup sizes
Look at the "24" lines in the above 2 files. Note that the output is different for hicolor (sound-juicer icon) and Tango (web-browser icon).
Created attachment 77395 [details] f-spot icon lookup Same here. I have a Tango-Plus theme which is just Tango theme plus some extra icons. I copied all size f-spot icons from hicolor to Tango-Plus and this is what I got
Created attachment 77396 [details] Tango-Plus icon theme try this theme with Tango: blurry f-spot icon with Tango-Plus: sharp f-spot icon
Patch committed to trunk.