GNOME Bugzilla – Bug 343419
New module: zip method
Last modified: 2010-05-13 17:52:25 UTC
I announced some weeks ago that I was working on a ZIP method, but I don't have time to finish it ATM so I'm attaching it as a work basis for others. Some more advanced features like Zip64 are not implemented, and the zip file information is not removed from the hash table as the file properties change, and the cache is never auto-freed before module shutdown.
Created attachment 66483 [details] [review] Proposed (unfinished) implementation
There is code to handle zips in libgsf which could be used here. It may be easier to just do a libgsf wrapper for gnome-vfs so that OLE2 files could also be supported.
Created attachment 66586 [details] [review] small bug fix to the original patch Since there seems to be no other appropriate place, I'm posting some bugs I noticed along with a patch to fix them: 1. In do_open_directory(): zip_file_ref() is redundant; refcount is already at 2 upon successful completion of lookup_or_create_file(). 2. In zip_file_entry_nodes_traverse_free(): g_free'ing the GNode in here leads to a memory error. Instead, call g_node_destroy() after g_node_traverse() in zip_file_unref().
gnome-vfs is not actively developed anymore and has been replaced by gvfs. Is this still valid in a recent GNOME version (2.28 or 2.30) which uses gvfs? If this is still an issue for gvfs please file a new bug report against gvfs with good steps to reproduce, or move this existing report to the product gvfs. If this is not an issue anymore in a recent GNOME version, please close this report as RESOLVED OBSOLETE.
Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for. Thanks!