After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 343334 - GstCollectPads testsuite and fixes
GstCollectPads testsuite and fixes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.7
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-29 21:56 UTC by Alessandro Decina
Modified: 2006-05-30 09:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Testsuite and fixes (8.97 KB, patch)
2006-05-29 21:56 UTC, Alessandro Decina 		none Details | Review

Description Alessandro Decina 2006-05-29 21:56:00 UTC 
GstCollectPads leaks abidata.ABI.pad_list and doesn't unlock _PADS_PAD_LOCK when gst_collect_pads_remove_pad is called with a pad which hasn't been added.
Comment 1 Alessandro Decina 2006-05-29 21:56:46 UTC 
Created attachment 66446 [details] [review]
Testsuite and fixes
Comment 2 Wim Taymans 2006-05-30 09:42:42 UTC 
        Patch by: Alessandro Decina <alessandro at nnva dot org>

        * libs/gst/base/gstcollectpads.c: (gst_collect_pads_remove_pad):
        Unlock mutex when removing an unknown pad.
        Fixes #343334.

        * tests/check/Makefile.am:
        * tests/check/libs/collectpads.c: (collected_cb), (push_buffer),
        (push_event), (setup), (teardown), (GST_START_TEST),
        (gst_collect_pads_suite), (main):
        Added collecpads check, disabled for now as check crashes for
        some reason.