After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 343281 - [subparse] support for JACOSub subtitles
[subparse] support for JACOSub subtitles
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-29 09:23 UTC by Joni Valtanen
Modified: 2009-09-10 09:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
JACOsub support for GStreamer (20.31 KB, patch)
2006-05-29 09:44 UTC, Joni Valtanen
needs-work Details | Review

Description Joni Valtanen 2006-05-29 09:23:20 UTC
Please describe the problem:
gst-plugins-base subparse plugin does not support JACOSub subtitle (jss)

Information:
JACOsub Script File Format Specification - http://unicorn.us.com/jacosub/jscripts.html
Comment 1 Joni Valtanen 2006-05-29 09:44:09 UTC
Created attachment 66407 [details] [review]
JACOsub support for GStreamer

It works but there might be unnessessary string copying etc.

How it works:
1. Puts line to buffer with time.
2. Gets new line
3.0 Checks if next line is same time than previous
3.1 If time is not same? Returns buffered line and go to 1.
3.2 If time is same? Copy only text to buffer.
4. Go to 1.

Same time in two subtitles is speciality of subtitle format. There is also newline, directive and tag cases implemented.

TODO:
-Get time from lines like: @0007000 @0008000  Subtitle....
-Better format detect. When ever  gst_sub_parse_data_format_autodetect is fixed.
Comment 2 Edward Hervey 2009-03-11 08:47:49 UTC
Joni, can you provide an updated patch for current git master ?
Comment 3 Sebastian Dröge (slomo) 2009-09-10 07:27:48 UTC
That, and you could use g_strstrip() instead your own one. The typefinder should be improved too, the regex is very generic and the other two checks too. I guess this one is likely to give false positives.
Comment 4 Joni Valtanen 2009-09-10 09:06:06 UTC
Just drop this patch.

Patch was my first steps with glib and gobject. There is many things I would do another way.

Another reason for the drop is that I haven't seen any application using Jacosub since I wrote this patch.

My opinion is that there is no use for bad plugin for rare subtitle format.