After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 343140 - Crash while starting up
Crash while starting up
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
2.3.x
Other All
: Normal critical
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2006-05-27 22:36 UTC by Will
Modified: 2008-01-15 14:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
one of the .vbr files in the folder (60 bytes, application/octet-stream)
2006-05-29 15:17 UTC, Will
Details

Description Will 2006-05-27 22:36:24 UTC
While the startup window for GIMP says "Looking for data files," the application crashes when it gets to brushes. This happens every time I try to run GIMP, but it worked fine on startup twice before this. I made my own brushes and inserted them into the brushes folder of GIMP prior to the crashes. Maybe this has something to do with it?
Comment 1 Will 2006-05-27 23:07:54 UTC
Update: This still happens after multiple uninstalls / reinstalls.
Comment 2 Will 2006-05-28 15:54:54 UTC
Another update: The GIMP console gives me the following debug message :
<gimp-console-2.3.exe:696>: Gimp-Core-CRITICAL **: gimp_brush_generated_new: assertion '*name != '\0'' failed

Anybody else get this bug? I already tried restarting and reinstalling.
Comment 3 Sven Neumann 2006-05-29 09:12:09 UTC
Can you please have a look at the personal brushes folder and look for .vbr files. You can have a look at the file using a text editor. The name of the brush is in the third line. Perhaps one of the files is corrupt?

We should definitely make the brush loader more robust. So if you find a corrupt brush file in your brushes folder, please attach it to this bug-report so that we can adapt the loader not to crash.
Comment 4 Will 2006-05-29 15:17:10 UTC
Created attachment 66413 [details]
one of the .vbr files in the folder

maybe this is the one that is corrupt, as it has no file name but the extention .vbr.
Comment 5 Sven Neumann 2006-05-29 15:22:14 UTC
Yes, looks as if we need to tell the brush loader to ignore files that don't include a name. And we should fix the brush saving code to always require a name.
Comment 6 Sven Neumann 2006-05-29 15:44:36 UTC
2006-05-29  Sven Neumann  <sven@gimp.org>

	* app/core/gimpbrushgenerated.c (gimp_brush_generated_load): don't
	choke on brush files with empty names (bug #343140).
	(gimp_brush_generated_save): warn about brushes with empty names.
Comment 7 Michael Natterer 2006-05-30 15:43:37 UTC
Related fix:

2006-05-30  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpdataeditor.c (gimp_data_editor_name_activate)
	* app/widgets/gimpdatafactoryview.c
	(gimp_data_factory_view_tree_name_edited): strip the newly
	entered name from whitespace and reject empty names.