After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 343122 - [taglib] new apev2mux element
[taglib] new apev2mux element
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-27 17:05 UTC by Sebastian Dröge (slomo)
Modified: 2006-05-30 16:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
apev2mux.diff (19.49 KB, patch)
2006-05-27 17:06 UTC, Sebastian Dröge (slomo) 		none Details | Review
apev2mux-check.diff (12.54 KB, patch)
2006-05-27 17:30 UTC, Sebastian Dröge (slomo) 		none Details | Review
updated patch (31.25 KB, patch)
2006-05-28 14:54 UTC, Tim-Philipp Müller 		committed Details | Review

Description Sebastian Dröge (slomo) 2006-05-27 17:05:13 UTC 
Hi,
attached is a patch against plugins-good CVS that
a) moves the plugin initialization code from gstid3v2mux.cc to gsttaglibmux.c
b) adds a new element, mostly an equivalent of gstid3v2mux.cc for muxing APEv2 tags, including documentation and autotools changes

Bye
Comment 1 Sebastian Dröge (slomo) 2006-05-27 17:06:02 UTC 
Created attachment 66338 [details] [review]
apev2mux.diff

the patch adding all parts mentioned above
Comment 2 Sebastian Dröge (slomo) 2006-05-27 17:30:25 UTC 
Created attachment 66340 [details] [review]
apev2mux-check.diff

test case for the new apev2mux element, mostly a copy of the one for the id3v2 muxer
Comment 3 Tim-Philipp Müller 2006-05-28 14:54:35 UTC 
Created attachment 66373 [details] [review]
updated patch

After fixing the test case (it should actually check track number/count and replagain stuff in _check_tags() - same bug as in id3v2mux test case), it appears the replaygain tags should be REPLAYGAIN_FOO_BAR instead of REPLAY_GAIN_FOO_BAR - sometimes unit tests are actually useful :)

Updated patch against gst-plugins-good:

 - fixed test case (see above)

 - fixed replay gain tags

 - handle TRACK_COUNT tag without TRACK_NUMBER tag

 - add code for ALBUM_VOLUME_NUMBER and COUNT (disabled for now,
   should also be added to the demuxer and the test case)

 - in ext/taglib/Makefile.am
     noinst_HEADERS = gsttaglibmux.h gstid3v2mux.h gstapev2mux.cc
   should be
     noinst_HEADERS = gsttaglibmux.h gstid3v2mux.h gstapev2mux.h
Comment 4 Sebastian Dröge (slomo) 2006-05-28 22:12:40 UTC 
Thanks, looks perfect now :)
Comment 5 Tim-Philipp Müller 2006-05-30 16:52:39 UTC 
2006-05-30  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Sebastian Dröge  <mail at slomosnail de >

        * docs/plugins/gst-plugins-good-plugins-docs.sgml:
        * docs/plugins/gst-plugins-good-plugins-sections.txt:
        * ext/taglib/Makefile.am:
        * ext/taglib/gstapev2mux.cc:
        * ext/taglib/gstapev2mux.h:
        * ext/taglib/gstid3v2mux.cc:
        * ext/taglib/gsttaglibmux.c: (plugin_init):
        * ext/taglib/gsttaglibmux.h:
          Add apev2mux element (#343122).

        * tests/check/Makefile.am:
        * tests/check/elements/apev2mux.c:
        (test_taglib_apev2mux_create_tags),
        (test_taglib_apev2mux_check_tags), (fill_mp3_buffer), (got_buffer),
        (demux_pad_added), (test_taglib_apev2mux_check_output_buffer),
        (test_taglib_apev2mux_with_tags), (GST_START_TEST),
        (apev2mux_suite), (main):
          Add unit test for apev2mux element.