After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 343085 - Typos in configure.in causes mishandling of --disable-{speech,a11y,japanese}
Typos in configure.in causes mishandling of --disable-{speech,a11y,japanese}
Status: RESOLVED FIXED
Product: dasher
Classification: Applications
Component: general
4.0.x
Other Linux
: Normal normal
: ---
Assigned To: Phil Cowans
Phil Cowans
Depends on:
Blocks:
 
 
Reported: 2006-05-27 08:12 UTC by Leonardo Boshell
Modified: 2006-05-28 02:31 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
dasher-4.0.2-fix_enable_flags.patch (1.05 KB, patch)
2006-05-27 08:14 UTC, Leonardo Boshell 		committed Details | Review

Description Leonardo Boshell 2006-05-27 08:12:59 UTC 
In dasher-3.x.x, the configure script had the --with-speech and --with-a11y flags, with have been replaced by --enable-speech and --enable-a11y, but the associated logic in configure.in still uses $withval, when it should use $enableval (this happens also with the new --enable-japanese option).

Because of this bug, calling configure with, for example, "--with-gnome --disable-speech" yields a problem, as it would set WITHSPEECH to true.

I'll attach a simple patch to correct this.

Thanks.
Comment 1 Leonardo Boshell 2006-05-27 08:14:17 UTC 
Created attachment 66319 [details] [review]
dasher-4.0.2-fix_enable_flags.patch
Comment 2 Behdad Esfahbod 2006-05-28 02:31:41 UTC 
Thanks.  Committed to HEAD.  Phil, is there a branch that this should be committed to?

2006-05-27  Behdad Esfahbod  <behdad@gnome.org>

        * configure.in: Bug 343085 – Typos in configure.in causes mishandling
        of --disable-{speech,a11y,japanese}