After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 343026 - 'gimp-channel-combine-masks' not UNDOable
'gimp-channel-combine-masks' not UNDOable
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: libgimp
git master
Other All
: Normal normal
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2006-05-26 12:58 UTC by saulgoode
Modified: 2006-05-29 11:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed fix (1.38 KB, patch)
2006-05-29 11:24 UTC, Sven Neumann
committed Details | Review

Description saulgoode 2006-05-26 12:58:43 UTC
Please describe the problem:
The PDB function 'gimp-channel-combine-masks' does not appear to register with
the UNDO history. 



Steps to reproduce:
1. Open a new document in the GIMP (any size). 
2. Open the script-fu console and type the following command:
  (set! image #)
where the "#" should be replaced with the number that follows the image name in
the title bar of the image (equals "1" if this is the first image opened after
starting the GIMP).

3. Select a rectangular region and type the following command:
  (set! rect (car (gimp-selection-save image)))
4. Select a elliptical region and type the following command:
  (set! circle (car (gimp-selection-save image)))

5. Type the following command:
  (gimp-channel-combine-masks rect circle CHANNEL-OP-INTERSECT 0 0 )



Actual results:
The Edit menu shows "Undo Add Channel" as its first item (the "Add Channel"
operation corresponds to Step 4 in the preceding section) and the operation is
not UNDOable.

Expected results:
The Edit menu should display something like "Undo Combine Masks" and the
operation should be UNDOable.

Does this happen every time?
Yes.

Other information:
Comment 1 Sven Neumann 2006-05-29 11:24:02 UTC
Created attachment 66412 [details] [review]
proposed fix

The attached patch should fix the problem.
Comment 2 Sven Neumann 2006-05-29 11:29:26 UTC
Applied to CVS HEAD:

2006-05-29  Sven Neumann  <sven@gimp.org>

	* tools/pdbgen/pdb/channel.pdb (channel_combine_masks): push a
	channel undo. Fixes bug #343026.

	* app/pdb/channel_cmds.c: regenerated.