After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 342831 - gdm could provide -nodaemon option for compatibility
gdm could provide -nodaemon option for compatibility
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-24 18:51 UTC by Ray Strode [halfline]
Modified: 2006-05-24 21:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add back support for -nodaemon (808 bytes, patch)
2006-05-24 18:53 UTC, Ray Strode [halfline]
committed Details | Review

Description Ray Strode [halfline] 2006-05-24 18:51:21 UTC
Hi,

A couple of weeks ago GDM lost the "-nodaemon" option when it transitioned over to using GOption.  This ended up causing problems in Fedora because our init scripts passed the old option and so GDM daemonized on start up.

This causes problems because we have code to watch for it to exit and restart it automatically.  Since it daemonizes, it exits immediately and we end up restarting it over and over again in a tight loop causing the user's CPU usage to jump to 100%.

See http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192461 for more details.

One potential solution would have been to change our initscripts to use --nodaemon instead of -nodaemon.  This would be a bit awkward because we use the same scripts for KDM and XDM and they only supported the one-dash variant of -nodaemon.

Another option would be to add support back to GDM for -nodaemon.  Arguably, the command line interface of GDM is part of it's API, so it would be nice if it still supported the -nodaemon option for backward compatibility with itself and XDM.
Comment 1 Ray Strode [halfline] 2006-05-24 18:53:12 UTC
Created attachment 66144 [details] [review]
Add back support for -nodaemon

I built this patch into Rawhide last night and it seemed to fix the problem for users.  It's a tiny patch that makes gdm treat -nodaemon like --nodaemon.
Comment 2 Brian Cameron 2006-05-24 21:17:49 UTC
Thanks, Ray, for fixing this.  Patch applied to CVS head.