After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 342817 - crash trying to view profile image
crash trying to view profile image
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: image viewer
git master
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-24 16:00 UTC by William Jon McCann
Modified: 2006-06-01 01:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
image (1.36 KB, image/png)
2006-05-24 16:01 UTC, William Jon McCann
  Details
patch making sure thumbnail is at least 1px large (691 bytes, patch)
2006-05-29 20:15 UTC, Felix Riemann
none Details | Review
patch for eog-ng branch (708 bytes, patch)
2006-05-31 15:33 UTC, Felix Riemann
none Details | Review

Description William Jon McCann 2006-05-24 16:00:16 UTC
I was trying to use plot-timeline.py to make some pretty strace logs and the png output was messed up somehow.  But trying to view it with eog caused a crash.  Gimp is able to view it but there is clearly something wrong with it.

Backtrace was generated from '/opt/gnome/bin/eog'

Using host libthread_db library "/lib/libthread_db.so.1".
`shared object read from target memory' has disappeared; keeping its symbols.
[Thread debugging using libthread_db enabled]
[New Thread -1208523072 (LWP 20185)]
[New Thread -1222632544 (LWP 20187)]
[New Thread -1210651744 (LWP 20186)]
0x00abe402 in __kernel_vsyscall ()

Thread 1 (Thread -1208523072 (LWP 20185))

  • #0 __kernel_vsyscall
  • #1 __waitpid_nocancel
    from /lib/libpthread.so.0
  • #2 libgnomeui_segv_handle
    at gnome-ui-init.c line 812

Comment 1 William Jon McCann 2006-05-24 16:01:28 UTC
Created attachment 66138 [details]
image
Comment 2 Felix Riemann 2006-05-29 20:06:29 UTC
The problem here is the extreme aspect ratio (116.6:1) of the image. The thumbnailing code in eog-collection-item.c:159 then calculates a scaling factor of  0.069. This gets the width down to 96 px but would produce a height of 0(.822)px. 
gnome_thumbnail_scale_down_pixbuf() uses gdk_pixbuf_new which does not work with 0px sizes.
Comment 3 Felix Riemann 2006-05-29 20:15:48 UTC
Created attachment 66434 [details] [review]
patch making sure thumbnail is at least 1px large

This makes sure that the thumbnail is at least 1 px high/wide.
Please try if it fixes the crash for you.
Comment 4 Felix Riemann 2006-05-31 15:33:32 UTC
Created attachment 66543 [details] [review]
patch for eog-ng branch

This patch fixed it in the eog-ng branch.
Comment 5 Lucas Rocha 2006-06-01 01:29:51 UTC
Fixed in gnome-2-14, HEAD and eog-ng branches. Thanks!

2006-05-31  Lucas Rocha  <lucasr@gnome.org>

        * libeog/eog-collection-item.c (set_pixbuf): making sure thumbnail
        is at least 1px large (Fixes bug #342817). Patch from
        Felix Riemann <felix@hsgheli.de>.