GNOME Bugzilla – Bug 342804
PATCH: use icon from theme
Last modified: 2008-03-31 21:42:10 UTC
wrt the GnomeGoal [1], here are two patches. The first one just does what the goal says, ie moves the icon into the theme dir, and use it from there. The second one drops the gnome-terminal icon and uses the one defined in the Icon Naming Specification : utilities-terminal. This one should be present in all the themes so IMHO this way is the best way to go, since gnome-terminal is the desktop's terminal emulation application. [1] http://live.gnome.org/GnomeGoals/AppIcon [2] http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html (table 4)
Created attachment 66123 [details] [review] move icon to theme
Created attachment 66124 [details] [review] use utilities-terminal icon from theme
*** Bug 334513 has been marked as a duplicate of this bug. ***
ndering if the specifics of bug 126081 have been taken into account in this patch ? That is the terminal icon is either the "default" terminal icon, or the one defined in the current profile. Just mentioning this, as it just didn't seem all that simple from the other bug report, I was wondering if these are in fact dupes. Another terminal related icon problem is that it uses the old icon selector dialogue to change the profile icon. (I mention this here rather than file a new bug report...) Love, Karderio.
OK, gnome-terminal should NOT be installing utilities-terminal into hicolor. That entirely defeats the purpose of having the specs in the first place, as it promotes conflict between applications. What should happen is gnome-terminal needs to actually use the icon from the theme, rather than hardcoding the path to the one it installs, and then, it should stop installing gnome-terminal.png, and simply use "utilities-terminal" as the fallback icon name, from the theme.
(In reply to comment #5) > OK, gnome-terminal should NOT be installing utilities-terminal into hicolor. > That entirely defeats the purpose of having the specs in the first place, as it > promotes conflict between applications. The second patch does not install anything in hicolor, it relies on the presence of the icon from the spec. I don't know if it's right to do so but gedit and epiphany do the same, for instance. > What should happen is gnome-terminal > needs to actually use the icon from the theme, rather than hardcoding the path > to the one it installs, and then, it should stop installing gnome-terminal.png, > and simply use "utilities-terminal" as the fallback icon name, from the theme. That's what the second patch does.
Considering the problems with profile icons and the second patch, I'll apply the first and, during the next release cycle, we'll figure something out regarding the second (unless someone cooks up a good patch soon and we get permission to break the UI freeze). As I stated on bug #126081, I think the about-me capplet handles this (unsetting an image) quite nicely.
>"Considering the problems with profile icons and the second patch" What are these problems please ? Looking at the patch (quickly) I'd say that this could break custom profile icons and there still isn't a revert button - is this true ? What else is wrong ? I don't mind having a look into this, it doesn't seem too hard but I feel it is important for consistency. Thanks. Love, Karderio.
ping?
(In reply to comment #7) > Considering the problems with profile icons and the second patch, I'll apply > the first and, during the next release cycle, we'll figure something out > regarding the second (unless someone cooks up a good patch soon and we get > permission to break the UI freeze). Please don't apply the first patch. GNOME Terminal should not be installing the terminal icon to the theme, but instead should rely on it being there. The patch to use the spec named icon, and always fall back to it if no profile icon is specified, is the only one that needs to get in. Once that's in, gnome-terminal can just not install an icon at all, as the icon is provided by gnome-icon-theme.
Has there been any activity on this?
This is pretty much dupe of bug 126081, but not duping because of discussion. I'm yet to go over all the discussion and decide what to do. Same issue reported against gucharmap, bug 509718.
Behdad, I really hope we can solve this long standing issue soon, so that it will finally be fixed in GNOME 2.24. The blurry gnome-terminal icon really starts to annoy me. We aim for pixel perfection everywhere but we can't have it here because of some power user feature. IMHO the right thing to do would be to just remove this from the config dialog but keep the profile setting available in gconf, so anyone who really wants to customize the icon still can, and we won't break existing setups. I don't think people who care about this "feature" will feel strongly about having to set it using gconf-editor. Let's not miss another release cycle...
*** Bug 470309 has been marked as a duplicate of this bug. ***
As if anybody actually sets profile icons? :E
Fixed in svn. I'm leaving bug 126081 open since it has a (bitrotten) patch to remove the icon profile option.