After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 342734 - [matroskamux] might block on state-change
[matroskamux] might block on state-change
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.3
Other Linux
: Normal normal
: 0.10.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-23 19:52 UTC by Mark Nauwelaerts
Modified: 2006-05-23 20:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Possible patch (707 bytes, patch)
2006-05-23 19:55 UTC, Mark Nauwelaerts 		committed Details | Review

Description Mark Nauwelaerts 2006-05-23 19:52:59 UTC 
GstCollectPads specs/documentation require gst_collect_pads_stop to be invoked upon (e.g.) PAUSED_TO_READY before chaining up to the parent change state.
That way, the collect pads releases the threads so the parent can actually stop the streaming.  Currently, gst_collect_pads_stop is invoked after chaining up, which is fine in case of normal (eos) termination, but may not be in other cases.
Comment 1 Mark Nauwelaerts 2006-05-23 19:55:04 UTC 
Created attachment 66078 [details] [review]
Possible patch

(sigh) description (blabla) is longer than the patch :)
Comment 2 Tim-Philipp Müller 2006-05-23 20:15:28 UTC 
Indeed, nice catch!

 2006-05-23  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Mark Nauwelaerts  <manauw at skynet be>

        * gst/matroska/matroska-mux.c: (gst_matroska_mux_change_state):
          gst_collect_pads_stop() needs to be called before chaining up
          to the parent class (#342734).