GNOME Bugzilla – Bug 342694
Timeline not updated when changing or clearing Date Range
Last modified: 2006-06-06 15:24:47 UTC
You can set a date range graphically using the 'borders' of the timeline. But when you select a date range or clear the date range from the 'find' menu, the graphical timeline is not updated. Way to reproduce: 1) - Find > Set Date Range - the timeline is unchanged 2) - Select a Date Range using the timeline - Find > Clear Date Range - the timeline is not reset
Created attachment 66061 [details] [review] reset timeline limits on 'clear date range' A small patch to solve the second case of the bug report. Now, when you choose 'Clear Date Range', the limits of the TimeLine are reset. This patch also add an entry to the popup of the timeline to 'Clear Date Range' See also the screenshot below Any comments ?
Created attachment 66062 [details] the mandatory screenshot...
Please also see bug #324908
Created attachment 66120 [details] [review] update timeline limits with Set or Clear Date Range A new version of the patch to handle both cases. - the timeline is updated when you set a date range - the timeline is updated when you clear the date range - the selection is adjusted when you reverse the order - the selection is restored when you change from 'directory view' to 'month view' - a 'clear date range' menu item is added in the popup in 'month view' Someone to review it ??
Created attachment 66465 [details] [review] updated patch An updated patch, after review, comments and a patch from Thomas Van Machelen. Quoting Thomas: <snip> * fixes a bug in the sliding of the end limit (it took a month too much off) * only shows the Clear Data Range menu item when a range actually has been set * removes some of the code duplication you introduced in the TimeAdaptor class. <snap>
Looks good,committed.