After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 342526 - [avimux] dml index support, codec_data support, cleanups
[avimux] dml index support, codec_data support, cleanups
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.3
Other Linux
: Normal normal
: 0.10.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-21 21:32 UTC by Mark Nauwelaerts
Modified: 2006-05-22 14:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch implementing enhancements (24.44 KB, patch)
2006-05-21 21:33 UTC, Mark Nauwelaerts 		committed Details | Review

Description Mark Nauwelaerts 2006-05-21 21:32:05 UTC 
Some enhancements for avimux:
- odml (large file) index support
- storing of codec init data (e.g. huffyuv)
- some other fixes and clean ups here and there (e.g. some header calculations)
Comment 1 Mark Nauwelaerts 2006-05-21 21:33:28 UTC 
Created attachment 65968 [details] [review]
Patch implementing enhancements
Comment 2 Tim-Philipp Müller 2006-05-22 13:59:10 UTC 
Thanks, committed:

  2006-05-22  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Mark Nauwelaerts  <manauw at skynet be>

        * gst/avi/gstavimux.c: (gst_avi_mux_finalize), (gst_avi_mux_init),
        (gst_avi_mux_vidsink_set_caps), (gst_avi_mux_audsink_set_caps),
        (gst_avi_mux_write_tag), (gst_avi_mux_riff_get_avi_header),
        (gst_avi_mux_riff_get_avix_header), (gst_avi_mux_write_avix_index),
        (gst_avi_mux_add_index), (gst_avi_mux_bigfile),
        (gst_avi_mux_start_file), (gst_avi_mux_stop_file),
        (gst_avi_mux_handle_event), (gst_avi_mux_do_audio_buffer),
        (gst_avi_mux_do_video_buffer), (gst_avi_mux_do_one_buffer),
        (gst_avi_mux_change_state):
        * gst/avi/gstavimux.h:
          Some enhancements for avimux (#342526):
           - add odml (large file) index support
           - store codec init data (e.g. huffyuv)
           - miscellaneous other fixes/cleanups


Minor modifications made:
 - used gst_value_get_buffer() instead of g_value_peek_pointer()
 - i--;;  =>  i--;
 - used memcmp() rather than strncmp() to compare unsigned chars,
   otherwise gcc4 will throw warnings
 - added some casts to gst_avi_mux_write_avix_index() calls for
   the same reason.
Comment 3 Tim-Philipp Müller 2006-05-22 14:01:09 UTC 
Btw, since you are the OpenDML expert: any idea about bug #330623 by any chance? :)