After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 342455 - gfig plug-in has multiply-defined symbols
gfig plug-in has multiply-defined symbols
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
git master
Other All
: Normal minor
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2006-05-21 00:26 UTC by Daniel Richard G.
Modified: 2006-06-27 08:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to put extern variables where they belong (3.35 KB, patch)
2006-06-25 05:25 UTC, Daniel Richard G. 		none Details | Review

Description Daniel Richard G. 2006-05-21 00:26:57 UTC 
Please describe the problem:
When building with -fno-common, the linker chokes on the following 
multiply-defined symbols in plug-ins/gfig/:

 multiple definition of `dobj_class'
 multiple definition of `gfig_context'
 multiple definition of `gfig_drawable'
 multiple definition of `gfig_list'
 multiple definition of `org_scale_x_factor'
 multiple definition of `org_scale_y_factor'
 multiple definition of `top_level_dlg'
 multiple definition of `undo_level'
 multiple definition of `undo_table'

These symbols are erroneously declared as non-static and non-extern in 
gfig-dialog.h, gfig-dobject.h and gfig.h.

Steps to reproduce:
Build GIMP with -fno-common.

Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Sven Neumann 2006-06-21 11:41:49 UTC 
Really a minor issue, but we should fix this for 2.4.
Comment 2 Daniel Richard G. 2006-06-25 05:25:26 UTC 
Created attachment 67959 [details] [review]
Patch to put extern variables where they belong

Sigh... am I the only one building with -fno-common?

Five-minute job here, please tweak formatting as appropriate, etc.
Comment 3 Sven Neumann 2006-06-27 07:23:07 UTC 
Daniel, you are probably the only one who is fiddling with compiler options at all. For everyone else the defaults are just fine.
Comment 4 Sven Neumann 2006-06-27 08:07:24 UTC 
2006-06-27  Sven Neumann  <sven@gimp.org>

	* plug-ins/gfig/gfig-dialog.[ch]
	* plug-ins/gfig/gfig-dobject.h
	* plug-ins/gfig/gfig.[ch]: put extern variables where they belong.
	Patch from Daniel Richard G. (bug #342455).