After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 342237 - remove outdated vfs utils
remove outdated vfs utils
Status: RESOLVED FIXED
Product: eel
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-18 11:40 UTC by Paolo Borelli
Modified: 2006-05-24 13:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
first patch (23.10 KB, patch)
2006-05-18 11:45 UTC, Paolo Borelli
committed Details | Review
one liner for nautilus (626 bytes, patch)
2006-05-18 11:46 UTC, Paolo Borelli
committed Details | Review

Description Paolo Borelli 2006-05-18 11:40:22 UTC
eel-vfs-extensions.[ch] contains a bunch of functions that have been migrated to gnome-vfs a long time ago (2.2).

Since now eel is used only by nautilus and doesn't guarantee api/abi stability and since I saw that other unused functions were dropped in 2.15.1 I think it's a good time to get rid of lots of old code.
Comment 1 Paolo Borelli 2006-05-18 11:45:31 UTC
Created attachment 65759 [details] [review]
first patch

This takes care of the most low hanging fruits, a whole bunch of functions that were copied verbatim to gnome-vfs and that are already not used anymore in nautilus (except for one call to eel_uri_get_scheme for which a patch is attached below).

There are still some functions for which the same thing could be done (for instance make_uri_canonical etc), but they need more careful thought given that the copy in gnome-vfs seems to have diverged or they are still widely used in nautilus.
Comment 2 Paolo Borelli 2006-05-18 11:46:27 UTC
Created attachment 65760 [details] [review]
one liner for nautilus
Comment 3 Alexander Larsson 2006-05-24 13:00:50 UTC
Looks good. Please commit.
Comment 4 Paolo Borelli 2006-05-24 13:23:14 UTC
done.