After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 342165 - Avoid NOOP in impl_zoom_region_set_mag_factor
Avoid NOOP in impl_zoom_region_set_mag_factor
Status: RESOLVED FIXED
Product: gnome-mag
Classification: Deprecated
Component: magnifier-utility
0.12.x
Other All
: Normal enhancement
: ---
Assigned To: Carlos Eduardo Rodrigues Diógenes
bill.haneman
Depends on:
Blocks:
 
 
Reported: 2006-05-17 18:56 UTC by Carlos Eduardo Rodrigues Diógenes
Modified: 2006-11-27 21:59 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
Patch for this (836 bytes, patch)
2006-05-17 18:58 UTC, Carlos Eduardo Rodrigues Diógenes 		none Details | Review
The older patch does not compile, sorry, I will not make these mistakes again :-8 (837 bytes, patch)
2006-05-17 19:33 UTC, Carlos Eduardo Rodrigues Diógenes 		needs-work Details | Review
patch the issue (1000 bytes, patch)
2006-11-27 17:50 UTC, Carlos Eduardo Rodrigues Diógenes 		accepted-commit_now Details | Review

Description Carlos Eduardo Rodrigues Diógenes 2006-05-17 18:56:45 UTC 
We can verify if the actual mag factor is equal to the ones specified in the function parameters, so we can return and avoid the execution of a lot of NOOP operations.
Comment 1 Carlos Eduardo Rodrigues Diógenes 2006-05-17 18:58:29 UTC 
Created attachment 65717 [details] [review]
Patch for this
Comment 2 Carlos Eduardo Rodrigues Diógenes 2006-05-17 19:33:52 UTC 
Created attachment 65723 [details] [review]
The older patch does not compile, sorry, I will not make these mistakes again :-8
Comment 3 bill.haneman 2006-07-27 12:49:17 UTC 
Actually doesn't the new patch also put code in front of declarations?  It shouldn't do that...
Comment 4 Carlos Eduardo Rodrigues Diógenes 2006-11-27 17:50:24 UTC 
Created attachment 77230 [details] [review]
patch the issue
Comment 5 Carlos Eduardo Rodrigues Diógenes 2006-11-27 21:59:50 UTC 
Fixed in the development version. The fix will be available in the next major release. Thank you for your bug report.