After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 342147 - strings in nautilus-main.c are not translatable
strings in nautilus-main.c are not translatable
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Internationalization (i18n)
2.14.x
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-17 16:53 UTC by Stanislav Brabec
Modified: 2006-10-06 22:46 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
nautilus-i18n.patch (274 bytes, patch)
2006-05-17 17:01 UTC, Stanislav Brabec 		committed Details | Review
patch from Mandriva (649 bytes, patch)
2006-05-18 23:29 UTC, Sebastien Bacher 		none Details | Review

Description Stanislav Brabec 2006-05-17 16:53:10 UTC 
Please describe the problem:
strings in nautilus-main.c are not translatable due to improperly initialized
locale.

Steps to reproduce:
1. Open many windows
2. Look and window list title
3. You see untranslated "File Manager" not depending on language you are using.


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Stanislav Brabec 2006-05-17 17:01:34 UTC 
Created attachment 65697 [details] [review]
nautilus-i18n.patch

Proposed fix.
Comment 2 Christian Kirbach 2006-05-18 12:57:26 UTC 
Cannot confirm for de_DE locale.
Comment 3 Stanislav Brabec 2006-05-18 14:12:23 UTC 
Well, the proposed patch was tested in nautilus-2.12.2 in SuSE Linux 10.1. And the proposed patch fixed the problem.

But I guess that CVS HEAD (and 2.14) is affected, too, because
g_set_application_name (_("File Manager"));
is called before locale initialization (done later by gnome_program_init()).
Comment 4 Sebastien Bacher 2006-05-18 23:29:41 UTC 
Created attachment 65799 [details] [review]
patch from Mandriva

patch from the Mandriva package, they move the g_set_application_name call
Comment 5 Stanislav Brabec 2006-05-19 13:02:49 UTC 
Note that g_option_context_new(_(foo)) one line below has the same problem.
Comment 6 Christian Kirbach 2006-05-19 13:23:58 UTC 
confirming report since we have some issue that was dealt with in distributions
Comment 7 Federico Mena Quintero 2006-08-14 20:52:15 UTC 
Good catch.  I'll ping nautilus-list about this.
Comment 8 Federico Mena Quintero 2006-08-15 20:23:55 UTC 
Committed the patch from comment #1 to HEAD.
Comment 9 André Klapper 2006-10-06 19:09:38 UTC 
can this be closed then?
Comment 10 Federico Mena Quintero 2006-10-06 22:46:03 UTC 
Yes, sorry about that.  I evidently forgot to close the bug.