After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 342143 - [subparse] sami parser needs to escape characters
[subparse] sami parser needs to escape characters
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.8
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-17 16:11 UTC by Young-Ho Cha
Modified: 2006-05-17 17:48 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
escape string before collect buffer (1.02 KB, patch)
2006-05-17 16:12 UTC, Young-Ho Cha 		committed Details | Review

Description Young-Ho Cha 2006-05-17 16:11:50 UTC 
characters_sami() in gst/subparse/samiparser.c, collect content into buffer.

however, string has been unescaped, and buffer will be used pango markup.

therefore, before append into buffer, string must be escaped.

I'll attach a patch against this.
Comment 1 Young-Ho Cha 2006-05-17 16:12:36 UTC 
Created attachment 65687 [details] [review]
escape string before collect buffer
Comment 2 Tim-Philipp Müller 2006-05-17 17:48:55 UTC 
Committed, thanks!

 2006-05-17  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Young-Ho Cha  <ganadist chollian net>

        * gst/subparse/gstsubparse.c: (gst_sub_parse_dispose),
        (gst_sub_parse_class_init), (gst_sub_parse_init),
        (gst_sub_parse_set_property), (gst_sub_parse_get_property),
        (convert_encoding):
        * gst/subparse/gstsubparse.h:
          Add 'encoding' property (#341681).

        * gst/subparse/samiparse.c: (characters_sami):
          Output is pango markup, so we need to escape text
          between tags (#342143).