After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 341899 - Message showing background image size and type is not localized
Message showing background image size and type is not localized
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Background
2.10.x
Other All
: Normal normal
: ---
Assigned To: Rodney Dawes
Control-Center Maintainers
Depends on:
Blocks: Persian
 
 
Reported: 2006-05-15 21:16 UTC by Roozbeh Pournader
Modified: 2007-01-08 17:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch against head to fix the problem, only tested on 2.10.1 (1.03 KB, patch)
2006-05-15 21:24 UTC, Roozbeh Pournader
none Details | Review
better patch, using Q_ (1.28 KB, patch)
2006-05-15 23:20 UTC, Roozbeh Pournader
committed Details | Review

Description Roozbeh Pournader 2006-05-15 21:16:43 UTC
In gnome-background-properties, the high-level message showing the image type and size is not marked for localization. The message is "%s, %d %s x %d %s". This messages needs to be localized as:
1) Some languages like Persian and Arabic use another character for comma.
2) RTL langauges will need to add bidirectional marks around some parts to get a proper rendering of the message.
3) Some languages may prefer to localize "x" to a proper MULTIPLICATION SIGN (U+00D7).
4) Some langauge like Persian may need to localize %d to %Id in order to use localized digits.

The bug still exists in HEAD. Will attach a patch.

FarsiWeb's internal reference:
bug #265, control-center-persian-digits.patch, originally reported by Behdad Pournader, patch by Roozbeh Pournader
Comment 1 Roozbeh Pournader 2006-05-15 21:24:57 UTC
Created attachment 65541 [details] [review]
Patch against head to fix the problem, only tested on 2.10.1
Comment 2 Behdad Esfahbod 2006-05-15 23:13:47 UTC
Looks good to me.  I wanted to say I prefer a context string, but that makes it more error prune I guess.

Roozbeh: In GNOME we typically retain the asterisk at the left margin of comment blocks.
Comment 3 Roozbeh Pournader 2006-05-15 23:20:33 UTC
Created attachment 65556 [details] [review]
better patch, using Q_
Comment 4 Roozbeh Pournader 2006-05-15 23:25:54 UTC
(In reply to comment #2)
> Looks good to me.  I wanted to say I prefer a context string, but that makes it
> more error prune I guess.

But we should really have it that way. I changed my mind and did it this way even before seeing your comment. Anyway, the first patch will probably not work, since nothing that defines _() is included.

> Roozbeh: In GNOME we typically retain the asterisk at the left margin of
> comment blocks.

Ah, I just followed the style of the rest of the file.
Comment 5 André Klapper 2006-10-02 10:16:33 UTC
any progress here?
Comment 6 Rodney Dawes 2007-01-08 16:59:49 UTC
Apparently this was already committed without my approval, and the person didn't update the bug report. :(
Comment 7 André Klapper 2007-01-08 17:16:51 UTC
well, no feedback sometimes results in no feedback.
*shrug*
Comment 8 Rodney Dawes 2007-01-08 17:30:08 UTC
Well, it wasn't Roozbeh or Bedhad. It was an arbitrary third party, never involved in the bug, and whom I've never even heard of. I will have to e-mail them privately.
Comment 9 André Klapper 2007-01-08 17:54:22 UTC
uhm, okay, that's a different case then.