After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 341719 - bisection algorithm in ogg doesn't bisect in some cases
bisection algorithm in ogg doesn't bisect in some cases
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.6
Other Linux
: Normal normal
: 0.10.8
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 341756 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-05-14 10:52 UTC by Thomas Vander Stichele
Modified: 2006-05-15 15:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to not look at pad->first_time, which is always _NONE (1.22 KB, patch)
2006-05-14 10:58 UTC, Thomas Vander Stichele 		rejected Details | Review

Description Thomas Vander Stichele 2006-05-14 10:52:32 UTC 
Create an ogg file like this:

gst-launch -v videotestsrc num-buffers=1000 ! theoraenc keyframe-force=20 ! identity ! oggmux ! filesink location=video.ogg

Then play back using totem, seek to the middle, and notice how it takes 100% CPU and quite some time to get there.  Not very scrubby.

Attaching a patch to fix it
Comment 1 Thomas Vander Stichele 2006-05-14 10:58:27 UTC 
Created attachment 65423 [details] [review]
patch to not look at pad->first_time, which is always _NONE
Comment 2 Thomas Vander Stichele 2006-05-14 10:59:26 UTC 
could someone comment on what pad->first_time was used for, and why it got lost in the refactoring ?

Obviously that chunk of code should check for it being GST_CLOCK_TIME_NONE if it's to be reintroduced.
Comment 3 Sebastian Dröge (slomo) 2006-05-14 16:55:23 UTC 
This patch fixes bug #341756 too and I didn't see any regressions until now
Comment 4 Michael Smith 2006-05-14 17:23:52 UTC 
*** Bug 341756 has been marked as a duplicate of this bug. ***
Comment 5 Wim Taymans 2006-05-15 15:01:04 UTC 
        * ext/ogg/gstoggdemux.c: (gst_ogg_pad_submit_packet):
        Fix seeking performance in the case where a non-header
        packet has a 0 granulepos (busted theora case).
        Fixes #341719