After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 341696 - audioconvert crashes if converting from a format with no rear channels
audioconvert crashes if converting from a format with no rear channels
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.8
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-14 00:06 UTC by Michael Smith
Modified: 2006-05-15 09:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for crash (803 bytes, patch)
2006-05-14 00:07 UTC, Michael Smith
committed Details | Review
test for crashing case (8.73 KB, patch)
2006-05-14 10:53 UTC, Michael Smith
none Details | Review
fixed test (4.93 KB, patch)
2006-05-14 11:04 UTC, Michael Smith
committed Details | Review

Description Michael Smith 2006-05-14 00:06:35 UTC
A wrong check results in an audioconvert crash when setting up the mix matrices, if the output format has rear channels, the input format a centre, and the input has no rears.

Patch to be attached.
Comment 1 Michael Smith 2006-05-14 00:07:03 UTC
Created attachment 65410 [details] [review]
Patch for crash
Comment 2 Jan Schmidt 2006-05-14 10:09:04 UTC
this isn't a regression, so at this point I think we should leave it for the next release.
Comment 3 Michael Smith 2006-05-14 10:53:24 UTC
Created attachment 65422 [details] [review]
test for crashing case

This is a simple test for the crash case.
Comment 4 Michael Smith 2006-05-14 11:04:28 UTC
Created attachment 65427 [details] [review]
fixed test

Cleaned up the test, it had some bits left over from earlier experiments.
Comment 5 Michael Smith 2006-05-15 09:39:30 UTC
Committed post-freeze, including test.