After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 341587 - use goption parsing
use goption parsing
Status: RESOLVED FIXED
Product: ORBit2
Classification: Deprecated
Component: IDL compiler
unspecified
Other Linux
: Normal normal
: ---
Assigned To: ORBit maintainers
ORBit maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-12 21:25 UTC by Christian Persch
Modified: 2006-05-29 17:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (11.53 KB, patch)
2006-05-12 21:26 UTC, Christian Persch 		needs-work Details | Review
updated patch (16.46 KB, patch)
2006-05-15 13:22 UTC, Christian Persch 		committed Details | Review

Description Christian Persch 2006-05-12 21:25:13 UTC 
The IDL compiler uses popt now, it should use goption parsing.

I have a patch, but I've run into a problem: goption can't parse -I../../some/other/dir style options (i.e. without space between option and argument).

Still attaching the partial patch for safekeeping.
Comment 1 Christian Persch 2006-05-12 21:26:07 UTC 
Created attachment 65351 [details] [review]
patch
Comment 2 Christian Persch 2006-05-15 13:22:25 UTC 
Created attachment 65499 [details] [review]
updated patch

Complete patch.
Fixes up -I.. style options before goption parsing.
Comment 3 Michael Meeks 2006-05-17 11:04:25 UTC 
Does 'make check' pass ?

If you're 100% happy with the patch then, please do commit to HEAD - using GOption instead of popt is fine with me.
Comment 4 Christian Persch 2006-05-21 17:53:08 UTC 
'make check' passes.

There is no gnome-2-14 branch yet; do you want me to create one before committing to HEAD?
Comment 5 Michael Meeks 2006-05-22 07:57:24 UTC 
Oh, I guess for small changes like this (assuming there is no extra dependency issue) and given that it's well tested [ you tried building some Nautilus/libbonobo type modules too ? ] - then I see no problem with having it on HEAD with no branch.

Thanks.
Comment 6 Christian Persch 2006-05-29 17:58:42 UTC 
I compiled a few projects (bonobo, at-spi, nautilus) using the modified idl compiler, without problems.

2006-05-29  Christian Persch  <chpe@cvs.gnome.org>

        * configure.in: Remove popt check.
        * src/idl-compiler/orbit-idl-main.c: (cl_libIDL_version_callback),
        (cl_cpp_define_callback), (cl_cpp_include_callback),
        (cl_version_callback), (cl_c_output_formatter_callback), (main):
        * src/services/name/boot.c: (main): Port from popt to goption argument
        parsing. Bug #341587.