After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 341486 - patch to compile -Wl,--as-needed
patch to compile -Wl,--as-needed
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
1.4.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2006-05-11 23:37 UTC by John N. Laliberte
Modified: 2006-05-17 21:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
totem-1.4.0-as-needed.patch (3.54 KB, patch)
2006-05-11 23:37 UTC, John N. Laliberte 		needs-work Details | Review
totem-cvs-makefile.patch (784 bytes, patch)
2006-05-17 15:18 UTC, John N. Laliberte 		none Details | Review

Description John N. Laliberte 2006-05-11 23:37:06 UTC 
attached is a patch from Josh Nichols <nichoj@gentoo.org> to compile with
LDFLAGS="-Wl,--as-needed".

see:
http://bugs.gentoo.org/show_bug.cgi?id=128466
http://www.gentoo.org/proj/en/qa/asneeded.xml

for more information.

Thanks!
Comment 1 John N. Laliberte 2006-05-11 23:37:44 UTC 
Created attachment 65275 [details] [review]
totem-1.4.0-as-needed.patch
Comment 2 Bastien Nocera 2006-05-17 14:45:10 UTC 
This patch doesn't apply to recent versions. Could you update this patch to the current CVS HEAD?
Comment 3 John N. Laliberte 2006-05-17 15:15:47 UTC 
looks like almost the entire patch was applied to cvs minus what i'm going to attach.
Comment 4 John N. Laliberte 2006-05-17 15:18:31 UTC 
Created attachment 65682 [details] [review]
totem-cvs-makefile.patch

for src/Makefile.am
Comment 5 Bastien Nocera 2006-05-17 15:31:11 UTC 
Fixed in gnome-2-14 and HEAD, thanks for the patch.

2006-05-17  Bastien Nocera  <hadess@hadess.net>

        * src/Makefile.am: patch from Josh Nichols <nichoj@gentoo.org> to
        allow building with LDFLAGS="-Wl,--as-needed" (Closes: #341486)
Comment 6 Frederic Peters 2006-05-17 21:14:36 UTC 
JhAutobuild just reported a regression from this change; lots of undefined references.

See http://jhbuild.bxlug.be/builds/2006-05-17-0011/logs/totem/#build or http://jhbuild.bxlug.be/builds/2006-05-17-0011/logs/totem/build.log for the raw log.

(Build host running Debian Sarge)
Comment 7 Marinus Schraal 2006-05-17 21:25:23 UTC 
the patch misses the '\' behind 'backend/libbaconvideowidget.la'