GNOME Bugzilla – Bug 341369
memory leaks concerned with gtk_tree_view_new_with_tree_model()
Last modified: 2013-09-13 00:49:55 UTC
Please describe the problem: GtkTreeModel which is argument of gtk_tree_view_new_with_tree_model() should be unref. Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
Created attachment 65216 [details] [review] a patch
Created attachment 65355 [details] [review] one more As far as I checked, there is no more memory leak concerned with gtk_tree_view_new_with_model().
Looks good to commit. Thanks for the patch. Hiroyuki, please update the patches with a ChangeLog (and include one in your future submissions). This helps when somebody (mostly, me) wants to pick the patches from Bugzilla and absorb them in their trees.
i have committed the second (#65355) of these two patches to both branches: http://cvs.gnome.org/viewcvs/evolution/filter/rule-editor.c?r1=1.67&r2=1.67.2.1 http://cvs.gnome.org/viewcvs/evolution/filter/rule-editor.c?r1=1.67&r2=1.68 http://cvs.gnome.org/viewcvs/evolution/plugins/exchange-operations/exchange-calendar.c?r1=1.18.2.4&r2=1.18.2.5 http://cvs.gnome.org/viewcvs/evolution/plugins/exchange-operations/exchange-calendar.c?r1=1.22&r2=1.23 http://cvs.gnome.org/viewcvs/evolution/plugins/exchange-operations/exchange-contacts.c?r1=1.19.2.4&r2=1.19.2.5 http://cvs.gnome.org/viewcvs/evolution/plugins/exchange-operations/exchange-contacts.c?r1=1.23&r2=1.24 http://cvs.gnome.org/viewcvs/evolution/plugins/save-attachments/save-attachments.c?r1=1.6&r2=1.6.2.1 http://cvs.gnome.org/viewcvs/evolution/plugins/save-attachments/save-attachments.c?r1=1.7&r2=1.8 fix will be included in stable evolution 2.6.3 and unstable evolution 2.7.4. thanks a lot!
committed the patch ahead of the release. Thanks Hiroyuki.