After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 341186 - vino support for Xgl
vino support for Xgl
Status: RESOLVED FIXED
Product: vino
Classification: Applications
Component: Server
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Vino Maintainer(s)
Vino Maintainer(s)
: 353642 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-05-09 21:09 UTC by Dan Winship
Modified: 2006-10-19 08:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
xgl support for vino (3.26 KB, patch)
2006-05-09 21:09 UTC, Dan Winship 		accepted-commit_now Details | Review

Description Dan Winship 2006-05-09 21:09:14 UTC 
This patch makes vino work with Xgl, which can't support the shared_pixmaps
feature of MIT-SHM because of how it implements pixmaps using OpenGL. (I
think it also fixes vino on X servers that don't support MIT-SHM at all, if
any such actually exists.)
Comment 1 Dan Winship 2006-05-09 21:09:39 UTC 
Created attachment 65115 [details] [review]
xgl support for vino
Comment 2 Mark McLoughlin 2006-10-16 07:50:20 UTC 
Looks good Dan - please commit to HEAD and gnome-2-16

Only change I'd make is that the XGetSubImage() doesn't need the XSync() - it already is synchronous.
Comment 3 Mark McLoughlin 2006-10-16 07:53:12 UTC 
*** Bug 353642 has been marked as a duplicate of this bug. ***
Comment 4 Dan Winship 2006-10-16 14:23:41 UTC 
committed to HEAD and gnome-2-16 (with XSync() moved)
Comment 5 Halton Huo 2006-10-19 08:41:28 UTC 
Verified on xsun, works well.