After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 340972 - expand the width of the file type drop down
expand the width of the file type drop down
Status: RESOLVED WONTFIX
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
2.9.x
Other All
: Normal minor
: Small fix
Assigned To: gtk-bugs
Federico Mena Quintero
Depends on:
Blocks:
 
 
Reported: 2006-05-08 02:31 UTC by Alan Horkan
Modified: 2014-12-22 18:23 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement



Description Alan Horkan 2006-05-08 02:31:39 UTC
Seeing the great work done in bug 163850 i felt compelled to ask if you could
fix the file type drop down in the file chooser to expand by default to fit the
available space.  A bigger target is easier to hit and a lot better than dead
space.  I'm also mildly optimistic a wider dialog will encourge some developers
to provide proper lables instead of just the extension such as ".jpg".  

Keep up the excellent work.  Thanks in advance.  



Other information:
Comment 1 Federico Mena Quintero 2007-01-25 20:07:58 UTC
This is easy to fix, in gtkfilechooserdefault.c:filter_pane_create().  Care to provide a patch?
Comment 2 Alan Horkan 2007-01-26 01:30:11 UTC
I'll give it a try over the next week or two, hopefully I'll remember to get it done and will be abel to test it properly (here's hoping it's a one liner).  
Comment 3 Alan Horkan 2007-01-26 18:06:58 UTC
I'll need to get a build enviroment sorted out to test this properly but it looks like just the one line in 
gtkfilechooserdefault.c:file_pane_create() 

  gtk_size_group_add_widget (size_group, impl->filter_combo_hbox);
  gtk_box_pack_end (GTK_BOX (vbox), impl->filter_combo_hbox, FALSE, FALSE, 0);

needs to be changed so that the Expand value is changed from false to true

  gtk_size_group_add_widget (size_group, impl->filter_combo_hbox);
  gtk_box_pack_end (GTK_BOX (vbox), impl->filter_combo_hbox, TRUE, FALSE, 0);

I can submit this change in patch format but I wont be able to test it out myself for a while yet.  
Comment 4 Matthias Clasen 2014-12-22 18:23:35 UTC
no patch materialized