After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 340831 - add toolbar icon for image collection
add toolbar icon for image collection
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: collection
2.19.x
Other All
: Normal minor
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-06 14:02 UTC by Emmanuel Touzery
Modified: 2007-06-29 23:26 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
patch to eog-ng branch (1.10 KB, patch)
2007-01-03 02:39 UTC, Bruno Boaventura
needs-work Details | Review
f-spot uses this icon (828 bytes, image/png)
2007-01-06 11:58 UTC, Bruno Boaventura
  Details
hope this works (8.58 KB, application/x-gzip)
2007-06-29 10:24 UTC, Andreas Nilsson
  Details

Description Emmanuel Touzery 2006-05-06 14:02:19 UTC
the new GUI of EOG in 2.14.x is just GREAT. it's exactly what it should be.
thank you very much! you can't compare it to what it was in 2.12.x.
anyway. a small wish: the "image collection" feature is great.

i think it should be made more discoverable by adding a new toolbar icon (toggle
button) "image collection". when you would click it, it would hide or show the
image collection.

Other information:
Comment 1 Claudio Saavedra 2006-12-31 19:57:12 UTC
Given that this bug mentioned in [1], I assume we want to fix it. Marking as new, gnome-love and increasing version.

If someone takes it, please generate a patch for SVN trunk (former CVS HEAD) and eog-ng branch.

[1] http://live.gnome.org/EyeOfGnome/EogNg, 
Comment 2 Bruno Boaventura 2007-01-03 02:39:42 UTC
Created attachment 79243 [details] [review]
patch to eog-ng branch

Claudio, if it is correct, I'll make a patch to HEAD too.

Note that: I used "gtk-select-color" as icon. Was the better I saw from GTK_STOCK_* for image collection. No?
Comment 3 Claudio Saavedra 2007-01-03 03:06:13 UTC
IMHO, we shouldn't use an icon whose purpose is other than the one we need, even when it looks familiar. Investigating the Icon Naming Specification[1] or asking their developers about the possibility of creating such an icon could be options.

Besides that, I think the patch is correct.

[1] http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html

Comment 4 Bruno Boaventura 2007-01-06 11:58:31 UTC
Created attachment 79521 [details]
f-spot uses this icon

Claudio, there is no icon for image collection at specifications. F-Spot uses this icon for "image browse". What do you think?
Comment 5 Claudio Saavedra 2007-01-06 13:43:15 UTC
I think we need Lucas' opinion on this. What do you think, Lucas?
Comment 6 Lucas Rocha 2007-01-06 17:08:18 UTC
IMHO, the icon is good enough. Some pending issues though:

1. What's the license of this icon? Compatible with EOG?
2. Is this icon available in all dimensions (16x16, 22x22, 24x24, and 32x32)?
2. Shouldn't it better to submit this icon to gnome-icon-theme? We can add the icon to EOG and when/if it gets into g-i-t we just use it there.

We need to decide about our default toolbar for EOG. Discussion about it should take place in bug #310455. Also, even if this item is not agreed for default toolbar, it should definitely be available on a possible editable toolbar (bug #393586).
Comment 7 Bruno Boaventura 2007-01-07 16:42:03 UTC
Option 3 (second 2) is better. How to submit to gnome-icon-theme. We have no icon for slideshow, f-spot have one.

A editable toolbar is a very good idea.
Comment 8 Claudio Saavedra 2007-01-30 23:06:24 UTC
(In reply to comment #7)
> Option 3 (second 2) is better. How to submit to gnome-icon-theme. We have no
> icon for slideshow, f-spot have one.

Normally, you open a bug in the freedesktop bugzilla, requesting the icon to be added to the icon specification. Once it's added, the artists take care of drawing it. I think this icon is not Tango'ified enough -- they could prefer to draw it from scratch; but I may be wrong and they'd just take it, if the license fits and all the needed sizes are available.

Comment 9 Andreas Nilsson 2007-02-04 18:39:33 UTC
The f-spot icon seem compatible with the style guidelines to me (and I draw these things all day ;) )
Comment 10 Lucas Rocha 2007-04-29 21:50:22 UTC
The problem I saw is that f-spot icon for image collection is only available in 24x24. 
Comment 11 Andreas Nilsson 2007-05-02 10:20:46 UTC
We can easily draw the other needed sizes of the f-spot icons since they are needed in both eog and f-spot.
I'll put it on my todo.

The icon license of the f-spot slideshow icon is gpl, just as f-spot itself.
You'll need to check with jimmac and dobey if they think it's ok to add it to g-i-t, we can make it themeable anyway if not.
Comment 12 Andreas Nilsson 2007-06-29 10:24:51 UTC
Created attachment 90852 [details]
hope this works
Comment 13 Lucas Rocha 2007-06-29 23:26:24 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.

2007-06-30  Lucas Rocha  <lucasr@geladinho>

        * data/eog-toolbar.xml: added image collection show/hide action button
        to the available list of toolbar items. Fixes bug #340831.
        * src/eog-window.c: use new image collection icon.
        * data/icons/*/actions/eog-image-collection.[png|svg]: new image
        collection icon. Thanks to Andreas Nilsson and Jakub Steiner.