After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 340721 - API: add GST_TAG_IMAGE
API: add GST_TAG_IMAGE
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 339704
 
 
Reported: 2006-05-05 10:14 UTC by Tim-Philipp Müller
Modified: 2006-05-09 10:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
adds GST_TAG_IMAGE (1.26 KB, patch)
2006-05-05 10:15 UTC, Tim-Philipp Müller 		committed Details | Review

Description Tim-Philipp Müller 2006-05-05 10:14:22 UTC 
Dear fellow GStreamer hackers,

it is about time to remedy the most serious of all regressions since GStreamer-0.8: the missing GST_TAG_IMAGE tag.

See bug #339704 for some related discussion.

I propose registering the tag as a GstBuffer type tag, that allows us to attach caps to it and caters for compressed and uncompressed images. Only disadvantage is that it won't look pretty when printing the tag as string in debug logs (we could work around this with a bew buffer flag though if it's really a concern).

Patch will follow shortly.
Comment 1 Tim-Philipp Müller 2006-05-05 10:15:39 UTC 
Created attachment 64850 [details] [review]
adds GST_TAG_IMAGE
Comment 2 Wim Taymans 2006-05-09 08:24:16 UTC 
looks ok, don't forget to add the "Since: 0.10.6" in the doc string.
Comment 3 Tim-Philipp Müller 2006-05-09 10:03:49 UTC 
Thanks, committed including the 'Since' bit (which I would have forgotten):

2006-05-09  Tim-Philipp Müller  <tim at centricular dot net>

       * gst/gsttaglist.c: (_gst_tag_initialize):
       * gst/gsttaglist.h:
         API: add GST_TAG_IMAGE tag (#340721).