After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 340676 - print backend type modules not correctly reregistering their types
print backend type modules not correctly reregistering their types
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Printing
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2006-05-04 19:24 UTC by Christian Persch
Modified: 2006-05-05 20:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
simple fix (5.65 KB, patch)
2006-05-04 19:25 UTC, Christian Persch
committed Details | Review

Description Christian Persch 2006-05-04 19:24:54 UTC
The print backends behave incorrectly when registering their types: they check whether the type was already registered and only register it if it was not. But when using gtypemodule, the types *need* to be reregistered every time the type module is loaded. This becomes a problem when you force the underlying gmodule to be resident (for debugging purposes): then the print backend won't load a 2nd time.
Comment 1 Christian Persch 2006-05-04 19:25:40 UTC
Created attachment 64829 [details] [review]
simple fix
Comment 2 Matthias Clasen 2006-05-05 20:12:46 UTC
Looks good to me, and matches what other modules in GTK+ do.
Comment 3 Christian Persch 2006-05-05 20:22:30 UTC
2006-05-05  Christian Persch  <chpe@cvs.gnome.org>

        * modules/printbackends/cups/gtkprintbackendcups.c:
        * modules/printbackends/lpr/gtkprintbackendlpr.c:
        * modules/printbackends/pdf/gtkprintbackendpdf.c: Always register
          the type with the type module, even if it had been registered
          before. Fixes bug #340676.