After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 340623 - [matroskademux] small memory leak
[matroskademux] small memory leak
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-04 12:39 UTC by Michal Benes
Modified: 2006-05-04 17:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch fixing memory leak (729 bytes, patch)
2006-05-04 12:42 UTC, Michal Benes 		committed Details | Review

Description Michal Benes 2006-05-04 12:39:49 UTC 
Matroska demuxer never dereferences pad capabilities stored in track context (they are created around line gst_matroska_demux_add_stream and stored around line 920)

Fix follows.
Comment 1 Michal Benes 2006-05-04 12:42:19 UTC 
Created attachment 64805 [details] [review]
Patch fixing memory leak
Comment 2 Tim-Philipp Müller 2006-05-04 13:00:57 UTC 
Thanks, looks good (although we could probably get rid of track->caps completely and just use GST_PAD_CAPS (stream->pad) in the two cases where we use it).

gst-plugins-good is frozen at the moment for the release, will commit once the release is out.
Comment 3 Tim-Philipp Müller 2006-05-04 17:28:01 UTC 
Thanks, committed:

 2006-05-04  Tim-Philipp Müller  <tim at centricular dot net>

       Patch by: Michal Benes  <michal dot benes at xeris dot cz>

       * gst/matroska/matroska-demux.c: (gst_matroska_demux_reset):
         Don't leak caps when freeing the stream context (#340623).