After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 340560 - Epiphany doesn't compile with LDFLAGS="-Wl,--as-needed"
Epiphany doesn't compile with LDFLAGS="-Wl,--as-needed"
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other Linux
: Normal minor
: ---
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2006-05-03 19:58 UTC by Thomas de Grenier de Latour
Modified: 2006-12-24 14:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
epiphany-2.14.1-as-needed.patch (883 bytes, patch)
2006-05-03 19:59 UTC, Thomas de Grenier de Latour
committed Details | Review

Description Thomas de Grenier de Latour 2006-05-03 19:58:54 UTC
There is an error in gecko.m4 macros: because of the way it passes libs to be linked by settings $LDFLAGS instead of $LIBS, they won't be at the right place in the linker arguments, and will be dropped if user's LDFLAGS contains "-Wl,--as-needed". Thus the GECKO_XPCOM_PROGRAM_CHECK test fails, and ./configure stops. I will attach a patch which fixes that (epiphany-2.14.1 here, but cvsview didn't show any relevant change in HEAD).

See also this Gentoo bug report, where this issue was discussed first:
https://bugs.gentoo.org/show_bug.cgi?id=132023
Comment 1 Thomas de Grenier de Latour 2006-05-03 19:59:35 UTC
Created attachment 64768 [details] [review]
epiphany-2.14.1-as-needed.patch
Comment 2 Christian Persch 2006-05-03 20:23:19 UTC
Thanks for the patch!

Ok to commit to epiphany HEAD and 2-14; afterwards we'll need to sync gecko.m4 to yelp HEAD and gnome-2-14, and devhelp and gnome-web-photo.

If you don't have cvs access, I'll check this in before next release.
Comment 3 Thomas de Grenier de Latour 2006-05-03 20:34:12 UTC
Thanks for your fast review and answer :)
And no, i don't have CVS access.
Comment 4 Christian Persch 2006-05-14 19:45:27 UTC
This is fixed in epiphany + e-e cvs HEAD; leaving open so we remember to sync to other modules.
Comment 5 Diego Escalante Urrelo (not reading bugmail) 2006-12-24 04:34:27 UTC
Sync'd already??