GNOME Bugzilla – Bug 340553
Deprecate AtkHyperlink::atk_hyperlink_is_selected_link
Last modified: 2009-10-07 11:43:53 UTC
Please describe the problem: The link should be a true accessible object child that can receive focus. The AT can check for ATK_STATE_FOCUSED instead. There is no corresponding AT-SPI interface to access this method anyway. This method is not needed and should be deprecated. Steps to reproduce: 1. 2. 3. Actual results: CORBA.NO_IMPLEMENT Expected results: Does this happen every time? yes. Other information:
This shouldn't be deprecated until all hyperlinks are full fledged objects, which won't (as I see it) be until at-spi's Document and Collection interfaces are in wider use. Why on earth would you log this severity as "major" ? I consider it either trivial or an enhancement (i.e. part of an enhancement process which includes changing the semantics of hyperlinks). Anyhow, at present, "normal" text hyperlinks are NOT children of their containing Hypertext instance, they are (and should be) accessed via the Hypertext:getLink method. I don't think that should change, and therefore I believe the isSelectedLink may still have utility (since it doesn't require querying the stateset of the Hyperlink for FOCUSSED, which is more expensive as an operation). There is also, in my mind, some question of whether/when hyperlink objects should be considered 'focussed'. The current model is that the containing hypertext object is the thing with focus, not the link, and I actually prefer that model except for things like image anchors and anchors that span multiple paragraphs. It is not proper for ATK_STATE_FOCUSSED to be TRUE on multiple objects in the hierarchy, so it appears to me that expressing 'focus' on (text-only) links may be problematic. Marking NEEDINFO as I don't think it's clear what we should do in this case.
I think that the state checked here should be ATK_STATE_SELECTED, rather than ATK_STATE_FOCUSSED, in most cases. On that basis I agree that the atk_hyperlink_is_selected_link() method seems redundant, and I'll mark it deprecated. In practice however the method will stick around and should continue to be implemented by many/most ATK services, in order to retain bincompat with older ATs and older versions of Gnome. However any standardization of ATK or conformance tests of ATK should omit this method from testing. Bill
Hey bill :) Could you please outline a way to get the same information atk_hyperlink_is_selected_link() provided? There is bug 573539 and up to now, one can't use ATK_STATE_SELECTED as AtkHyperlink is not an AtkObject :(
Bill: ping