After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 340535 - [PATCH] [WAITING_FOR_STRING_APPROVAL] Able To Proxy Into Same Account Multiple Times
[PATCH] [WAITING_FOR_STRING_APPROVAL] Able To Proxy Into Same Account Multipl...
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.6.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: Sankar P
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2006-05-03 14:45 UTC by David Richards
Modified: 2006-06-20 06:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix (2.22 KB, patch)
2006-05-26 09:40 UTC, Sankar P
accepted-commit_now Details | Review

Description David Richards 2006-05-03 14:45:36 UTC
Please describe the problem:
Evolution doesn't check to see if you are already proxied into an account and
allows you to do it again.  Each time that you do it, it adds a gconf key into
the calendar and task area of duplicate items.  When you close the Proxy from
the mailer, all of the extra gconf keys remain and you cannot delete them from
the UI.  YOu have to use the key editor and delete the entries by hand.

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Poornima 2006-05-04 06:36:30 UTC
Confirming this bug but it is not 'Major' bug i feel. As it is not regular user scenario trying to login multiple times.
Dave: you can change severity of the bug if you feel it is 'Major'.
Comment 2 David Richards 2006-05-04 13:08:48 UTC
This is a major bug for sure.  I did this the first time I tried Proxy and other people will for sure.  My expectation that proxy would proxy as it does in GroupWise and the UI would flip into another user.  But what it does is add another folder tree below your own, which is not visible at all unless you scroll down.  The UI doesn't tell you at all that you have proxied.  So I repeated the steps a few times before I noticed the issue.

Once you do this, it's impossible even with the gconf editor to remove all of the keys and clean up your session.  You have to blow out all of your settings and redo your account again from scratch.  We can't be doing this for all of the people that will make this error, and it will be a lot of people.

To me, something that causes you to have to re-do your whole Evo account is Major.
Comment 3 Sankar P 2006-05-26 09:40:53 UTC
Created attachment 66262 [details] [review]
Fix
Comment 4 parthasarathi susarla 2006-05-26 09:44:25 UTC
The patch looks fine and can go into HEAD.
It cannot be committed to the stable branch since it breaks the string freeze (and translations).
Comment 5 David Richards 2006-05-26 12:48:51 UTC
Guys-

   Would it be possible to apply to stable with the dialog removed and perform the check silently?  This is going to happen all the time once I put Proxy live and people are going to do it over and over again.
Comment 6 Harish Krishnaswamy 2006-05-31 08:48:39 UTC
The patch is not much useful in the absence of the error message or an alternate f/b to the user - It would just leave him more confused as he tries to login and 'nothing' happens if the account already exists.

I suggest - commit this to the HEAD, provide a custom fix to David's deployment temporarily and request string freeze breaks for stable branch/ SLED 10.
Comment 7 David Richards 2006-05-31 12:55:33 UTC
Harish:
      Great if we can get this into the build.  It really creates a headache and requires lots of poking around in gconf-editor to fix the entries.  You have to use gconf-editor to remove the entries, and then find the keys that store which calendars are checked and your default calendar.  Then you have to do the same thing for tasks.  One use did this 4 times and when they did the Proxy Logout it left behind 3 bad calendar entries and 3 bad task entries. :(
Comment 8 Poornima 2006-06-01 11:32:52 UTC
Verified this fix, it works as expected.
Comment 9 Sankar P 2006-06-12 08:40:29 UTC
Requested for String freeze break. Will commit it as soon as it is approved.
Comment 10 Sankar P 2006-06-20 06:34:32 UTC
Committed to HEAD and Branch.