After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 340491 - One layer merges should be permitted
One layer merges should be permitted
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
git master
Other All
: Normal enhancement
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2006-05-03 05:11 UTC by saulgoode
Modified: 2006-05-03 07:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
One layer merges (1.03 KB, patch)
2006-05-03 05:43 UTC, saulgoode
none Details | Review
the .rej file created when the previously attached patch failed (420 bytes, application/octet-stream)
2006-05-03 06:21 UTC, Carol
  Details

Description saulgoode 2006-05-03 05:11:16 UTC
Rather than have a merge of a single layer result in an error message,
 it might be preferable to have the operation apply the layer mask and the
Opacity setting to the layer.



Other information:
Currently a request to "merge visible layers" with only one layer visible or to
"merge down" when no lower layers (in the stack) are visible results in an error
popup to the user. There are a couple of situations for which this operation is
not unreasonable: in particular, to apply the layer's opacity setting.

I will follow this report with a patch that implements this change.
Comment 1 saulgoode 2006-05-03 05:43:24 UTC
Created attachment 64722 [details] [review]
One layer merges

Implements the following:

If a single layer is merged, that layer's mask is applied, the layer's opacity setting is applied, and the layer given a new opacity of 100%.

This patch actually just removes the multilayer restriction from the code.
Comment 2 Carol 2006-05-03 06:21:05 UTC
Created attachment 64723 [details]
the .rej file created when the previously attached patch failed
Comment 3 Sven Neumann 2006-05-03 07:25:20 UTC
Comment on attachment 64723 [details]
the .rej file created when the previously attached patch failed

obsolete, just ignore Carol
Comment 4 Sven Neumann 2006-05-03 07:43:19 UTC
2006-05-03  Sven Neumann  <sven@gimp.org>

	* app/core/gimpimage-merge.c: allow Merge operations on single
	layers as suggested in bug #340491.