After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 340455 - port notification plugin to gtkstatusicon
port notification plugin to gtkstatusicon
Status: RESOLVED FIXED
Product: xchat-gnome
Classification: Other
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: xchat-gnome maintainers
xchat-gnome maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-02 21:08 UTC by Christian Persch
Modified: 2006-10-14 05:21 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
patch (11.81 KB, patch)
2006-05-02 21:08 UTC, Christian Persch 		committed Details | Review

Description Christian Persch 2006-05-02 21:08:32 UTC 
Gtk 2.9 has GtkStatusIcon which replaces the eggtrayicon, and I ported the notification plugin to it.
Since gtk+ 2.10 isn't even released yet and I'm not sure how soon after that you want to increase the gtk requirement to 2.10, you may either want to wait until then to check this in, or alternatively I could add some configure/automake magic to build the old eggtraycode for gtk < 2.0 and the new code for 2.9/2.10 ?
Comment 1 Christian Persch 2006-05-02 21:08:58 UTC 
Created attachment 64691 [details] [review]
patch
Comment 2 Guillaume Desmottes 2006-05-03 07:45:54 UTC 
Thanks a lot for your work.
I suppose it will be commited after the GTK+ 2.10 release.

BTW, it would be fine than the status icon use the themable version of the x-g logo.
Comment 3 David Trowbridge 2006-05-04 01:39:27 UTC 
I'm happy to commit this once 2.10 is in the major distributions (I personally only care about gentoo, but fedora and ubuntu are probably important too)
Comment 4 David Trowbridge 2006-10-14 05:21:02 UTC 
2006-10-13  David Trowbridge  <trowbrds@gmail.com>

        * plugins/notification/notification.c:
        * plugins/notification/Makefile.am:
        * configure.ac:
        D plugins/notification/eggtrayicon.c:
        D plugins/notification/eggtrayicon.h:
          - Apply Christian Persch's patch to port the notification plugin to
            GtkStatusIcon, and bump the required GTK+ version to 2.10.0.